gx: use correct constant name for PASSCLR operation (#176)

mardy · web-flow · commit 0d23455c7f29 · 2024-06-23T20:02:36.000+02:00
In the alpha input we should use only GX_CA_* registers.  Both GX_CC_A2
and GX_CA_ZERO evaluate to 7, so this is just a cosmetic issue.

The existing error is probably the result of a misunderstanding during
reverse engineering.
diff --git a/libogc/gx.c b/libogc/gx.c
@@ -3858,7 +3858,7 @@ void GX_SetTevOp(u8 tevstage,u8 mode)
 			break;
 		case GX_PASSCLR:
 			GX_SetTevColorIn(tevstage,GX_CC_ZERO,GX_CC_ZERO,GX_CC_ZERO,defcolor);
-			GX_SetTevAlphaIn(tevstage,GX_CC_A2,GX_CC_A2,GX_CC_A2,defalpha);
+			GX_SetTevAlphaIn(tevstage,GX_CA_ZERO,GX_CA_ZERO,GX_CA_ZERO,defalpha);
 			break;
 	}
 	GX_SetTevColorOp(tevstage,GX_TEV_ADD,GX_TB_ZERO,GX_CS_SCALE_1,GX_TRUE,GX_TEVPREV);

Original file line number	Diff line number	Diff line change
`@@ -3858,7 +3858,7 @@ void GX_SetTevOp(u8 tevstage,u8 mode)`
`3858`	`3858`	`break;`
`3859`	`3859`	`case GX_PASSCLR:`
`3860`	`3860`	`GX_SetTevColorIn(tevstage,GX_CC_ZERO,GX_CC_ZERO,GX_CC_ZERO,defcolor);`
`3861`		`- GX_SetTevAlphaIn(tevstage,GX_CC_A2,GX_CC_A2,GX_CC_A2,defalpha);`
	`3861`	`+ GX_SetTevAlphaIn(tevstage,GX_CA_ZERO,GX_CA_ZERO,GX_CA_ZERO,defalpha);`
`3862`	`3862`	`break;`
`3863`	`3863`	`}`
`3864`	`3864`	`GX_SetTevColorOp(tevstage,GX_TEV_ADD,GX_TB_ZERO,GX_CS_SCALE_1,GX_TRUE,GX_TEVPREV);`