3.2.0 react-scripts/wptheme-scripts bin changes

Author: devloco

packages/react-scripts/bin/react-scripts.js

@@ -26,42 +26,35 @@ const nodeArgs = scriptIndex > 0 ? args.slice(0, scriptIndex) : [];
 
 script = script.replace(/cra/, ''); // wptheme -- added
 
-switch (script) {
-  case 'build':
-  case 'eject':
-  case 'start':
-  case 'test': {
-    const result = spawn.sync(
-      'node',
-      nodeArgs
-        .concat(require.resolve('../scripts/' + script))
-        .concat(args.slice(scriptIndex + 1)),
-      { stdio: 'inherit' }
-    );
-    if (result.signal) {
-      if (result.signal === 'SIGKILL') {
-        console.log(
-          'The build failed because the process exited too early. ' +
-            'This probably means the system ran out of memory or someone called ' +
-            '`kill -9` on the process.'
-        );
-      } else if (result.signal === 'SIGTERM') {
-        console.log(
-          'The build failed because the process exited too early. ' +
-            'Someone might have called `kill` or `killall`, or the system could ' +
-            'be shutting down.'
-        );
-      }
-      process.exit(1);
+if (['build', 'eject', 'start', 'test'].includes(script)) {
+  const result = spawn.sync(
+    'node',
+    nodeArgs
+      .concat(require.resolve('../scripts/' + script))
+      .concat(args.slice(scriptIndex + 1)),
+    { stdio: 'inherit' }
+  );
+  if (result.signal) {
+    if (result.signal === 'SIGKILL') {
+      console.log(
+        'The build failed because the process exited too early. ' +
+          'This probably means the system ran out of memory or someone called ' +
+          '`kill -9` on the process.'
+      );
+    } else if (result.signal === 'SIGTERM') {
+      console.log(
+        'The build failed because the process exited too early. ' +
+          'Someone might have called `kill` or `killall`, or the system could ' +
+          'be shutting down.'
+      );
     }
-    process.exit(result.status);
-    break;
+    process.exit(1);
   }
-  default:
-    console.log('Unknown script "' + script + '".');
-    console.log('Perhaps you need to update react-scripts?');
-    console.log(
-      'See: https://facebook.github.io/create-react-app/docs/updating-to-new-releases'
-    );
-    break;
+  process.exit(result.status);
+} else {
+  console.log('Unknown script "' + script + '".');
+  console.log('Perhaps you need to update react-scripts?');
+  console.log(
+    'See: https://github.com/devloco/create-react-wptheme#updating-existing-themes'
+  );
 }

packages/react-scripts/bin/wptheme-scripts.js

@@ -8,52 +8,55 @@
 
 'use strict';
 
+// Makes the script crash on unhandled rejections instead of silently
+// ignoring them. In the future, promise rejections that are not handled will
+// terminate the Node.js process with a non-zero exit code.
+process.on('unhandledRejection', err => {
+  throw err;
+});
+
 const spawn = require('react-dev-utils/crossSpawn');
 const args = process.argv.slice(2);
 
 const scriptIndex = args.findIndex(
   x => x === 'build' || x === 'start' || x === 'wpbuild' || x === 'wpstart'
 );
+let script = scriptIndex === -1 ? args[0] : args[scriptIndex]; // wptheme -- change to "let" to allow modification...
 const nodeArgs = scriptIndex > 0 ? args.slice(0, scriptIndex) : [];
 
-let script = scriptIndex === -1 ? args[0] : args[scriptIndex];
 if (!script.startsWith('wp')) {
   script = `wp${script}`;
 }
 
-switch (script) {
-  case 'wpbuild':
-  case 'wpstart': {
-    const result = spawn.sync(
-      'node',
-      nodeArgs
-        .concat(require.resolve('../scripts/' + script))
-        .concat(args.slice(scriptIndex + 1)),
-      { stdio: 'inherit' }
-    );
-    if (result.signal) {
-      if (result.signal === 'SIGKILL') {
-        console.log('The build failed because the process exited too early.');
-        console.log(
-          'This probably means the system ran out of memory or someone called `kill -9` on the process.'
-        );
-      } else if (result.signal === 'SIGTERM') {
-        console.log('The build failed because the process exited too early.');
-        console.log(
-          'Someone might have called `kill` or `killall`, or the system could be shutting down.'
-        );
-      }
-
-      process.exit(1);
+if (['wpbuild', 'wpstart'].includes(script)) {
+  const result = spawn.sync(
+    'node',
+    nodeArgs
+      .concat(require.resolve('../scripts/' + script))
+      .concat(args.slice(scriptIndex + 1)),
+    { stdio: 'inherit' }
+  );
+  if (result.signal) {
+    if (result.signal === 'SIGKILL') {
+      console.log(
+        'The build failed because the process exited too early. ' +
+          'This probably means the system ran out of memory or someone called ' +
+          '`kill -9` on the process.'
+      );
+    } else if (result.signal === 'SIGTERM') {
+      console.log(
+        'The build failed because the process exited too early. ' +
+          'Someone might have called `kill` or `killall`, or the system could ' +
+          'be shutting down.'
+      );
     }
-
-    process.exit(result.status);
-    break;
+    process.exit(1);
   }
-  default:
-    console.log('Unknown script "' + script + '".');
-    console.log(
-      "The original create-react-scripts commands are still available but must be prefixed with 'cra' (e.g. crastart, craeject, etc.)."
-    );
-    break;
+  process.exit(result.status);
+} else {
+  console.log('Unknown script "' + script + '".');
+  // console.log('Perhaps you need to update react-scripts?');
+  console.log(
+    "The original create-react-scripts commands are still available but must be prefixed with 'cra' (e.g. crastart, craeject, etc.)."
+  );
 }