Merge pull request godotengine#96399 from andyprice/fileperms

Repiteo · Repiteo · commit 030cc697719e · 2024-11-21T17:56:53.000-06:00
Unix: Don't create world-writable files when safe save is enabled
diff --git a/drivers/unix/file_access_unix.cpp b/drivers/unix/file_access_unix.cpp
@@ -118,7 +118,7 @@ Error FileAccessUnix::open_internal(const String &p_path, int p_mode_flags) {
 			last_error = ERR_FILE_CANT_OPEN;
 			return last_error;
 		}
-		fchmod(fd, 0666);
+		fchmod(fd, 0644);
 		path = String::utf8(cs.ptr());
 
 		f = fdopen(fd, mode_string);
diff --git a/drivers/unix/file_access_unix_pipe.cpp b/drivers/unix/file_access_unix_pipe.cpp
@@ -70,7 +70,7 @@ Error FileAccessUnixPipe::open_internal(const String &p_path, int p_mode_flags)
 	struct stat st = {};
 	int err = stat(path.utf8().get_data(), &st);
 	if (err) {
-		if (mkfifo(path.utf8().get_data(), 0666) != 0) {
+		if (mkfifo(path.utf8().get_data(), 0600) != 0) {
 			last_error = ERR_FILE_CANT_OPEN;
 			return last_error;
 		}

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ Error FileAccessUnix::open_internal(const String &p_path, int p_mode_flags) {`
`118`	`118`	`last_error = ERR_FILE_CANT_OPEN;`
`119`	`119`	`return last_error;`
`120`	`120`	`}`
`121`		`- fchmod(fd, 0666);`
	`121`	`+ fchmod(fd, 0644);`
`122`	`122`	`path = String::utf8(cs.ptr());`
`123`	`123`
`124`	`124`	`f = fdopen(fd, mode_string);`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ Error FileAccessUnixPipe::open_internal(const String &p_path, int p_mode_flags)`
`70`	`70`	`struct stat st = {};`
`71`	`71`	`int err = stat(path.utf8().get_data(), &st);`
`72`	`72`	`if (err) {`
`73`		`- if (mkfifo(path.utf8().get_data(), 0666) != 0) {`
	`73`	`+ if (mkfifo(path.utf8().get_data(), 0600) != 0) {`
`74`	`74`	`last_error = ERR_FILE_CANT_OPEN;`
`75`	`75`	`return last_error;`
`76`	`76`	`}`