Merge pull request godotengine#107088 from ProgrammerOnCoffee/make-shortcut-timer-internal

Repiteo · Repiteo · commit 092dc74e3b3e · 2025-06-03T15:30:25.000-05:00
Make `BaseButton`s' shortcut feedback timers internal
diff --git a/scene/gui/base_button.cpp b/scene/gui/base_button.cpp
@@ -452,7 +452,7 @@ void BaseButton::shortcut_input(const Ref<InputEvent> &p_event) {
 			if (shortcut_feedback_timer == nullptr) {
 				shortcut_feedback_timer = memnew(Timer);
 				shortcut_feedback_timer->set_one_shot(true);
-				add_child(shortcut_feedback_timer);
+				add_child(shortcut_feedback_timer, false, INTERNAL_MODE_BACK);
 				shortcut_feedback_timer->set_wait_time(GLOBAL_GET_CACHED(double, "gui/timers/button_shortcut_feedback_highlight_time"));
 				shortcut_feedback_timer->connect("timeout", callable_mp(this, &BaseButton::_shortcut_feedback_timeout));
 			}

Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,7 @@ void BaseButton::shortcut_input(const Ref<InputEvent> &p_event) {`
`452`	`452`	`if (shortcut_feedback_timer == nullptr) {`
`453`	`453`	`shortcut_feedback_timer = memnew(Timer);`
`454`	`454`	`shortcut_feedback_timer->set_one_shot(true);`
`455`		`- add_child(shortcut_feedback_timer);`
	`455`	`+ add_child(shortcut_feedback_timer, false, INTERNAL_MODE_BACK);`
`456`	`456`	`shortcut_feedback_timer->set_wait_time(GLOBAL_GET_CACHED(double, "gui/timers/button_shortcut_feedback_highlight_time"));`
`457`	`457`	`shortcut_feedback_timer->connect("timeout", callable_mp(this, &BaseButton::_shortcut_feedback_timeout));`
`458`	`458`	`}`