Skip to content

Commit 0e5e743

Browse files
committed
Bind compatibility GDExtension methods removed in 88418
These functions were likely not used, but we must ensure they are still bound to ensure API stability.
1 parent 6118592 commit 0e5e743

File tree

3 files changed

+60
-0
lines changed

3 files changed

+60
-0
lines changed
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
/**************************************************************************/
2+
/* gdextension.compat.inc */
3+
/**************************************************************************/
4+
/* This file is part of: */
5+
/* GODOT ENGINE */
6+
/* https://godotengine.org */
7+
/**************************************************************************/
8+
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
9+
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
10+
/* */
11+
/* Permission is hereby granted, free of charge, to any person obtaining */
12+
/* a copy of this software and associated documentation files (the */
13+
/* "Software"), to deal in the Software without restriction, including */
14+
/* without limitation the rights to use, copy, modify, merge, publish, */
15+
/* distribute, sublicense, and/or sell copies of the Software, and to */
16+
/* permit persons to whom the Software is furnished to do so, subject to */
17+
/* the following conditions: */
18+
/* */
19+
/* The above copyright notice and this permission notice shall be */
20+
/* included in all copies or substantial portions of the Software. */
21+
/* */
22+
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
23+
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
24+
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
25+
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
26+
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
27+
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
28+
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
29+
/**************************************************************************/
30+
31+
#ifndef DISABLE_DEPRECATED
32+
33+
Error GDExtension::_open_library_bind_compat_88418(const String &p_path, const String &p_entry_symbol) {
34+
return ERR_UNAVAILABLE;
35+
}
36+
37+
void GDExtension::_close_library_bind_compat_88418() {
38+
}
39+
40+
void GDExtension::_initialize_library_bind_compat_88418(InitializationLevel p_level) {
41+
}
42+
43+
void GDExtension::_bind_compatibility_methods() {
44+
ClassDB::bind_compatibility_method(D_METHOD("open_library", "path", "entry_symbol"), &GDExtension::_open_library_bind_compat_88418);
45+
ClassDB::bind_compatibility_method(D_METHOD("close_library"), &GDExtension::_close_library_bind_compat_88418);
46+
ClassDB::bind_compatibility_method(D_METHOD("initialize_library", "level"), &GDExtension::_initialize_library_bind_compat_88418);
47+
}
48+
49+
#endif

core/extension/gdextension.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
/**************************************************************************/
3030

3131
#include "gdextension.h"
32+
#include "gdextension.compat.inc"
33+
3234
#include "core/config/project_settings.h"
3335
#include "core/io/dir_access.h"
3436
#include "core/object/class_db.h"

core/extension/gdextension.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,15 @@ class GDExtension : public Resource {
136136
INITIALIZATION_LEVEL_EDITOR = GDEXTENSION_INITIALIZATION_EDITOR
137137
};
138138

139+
protected:
140+
#ifndef DISABLE_DEPRECATED
141+
Error _open_library_bind_compat_88418(const String &p_path, const String &p_entry_symbol);
142+
void _close_library_bind_compat_88418();
143+
void _initialize_library_bind_compat_88418(InitializationLevel p_level);
144+
static void _bind_compatibility_methods();
145+
#endif
146+
147+
public:
139148
bool is_library_open() const;
140149

141150
#ifdef TOOLS_ENABLED

0 commit comments

Comments
 (0)