Fix shift clicking on Add Sun/Environment to Scene buttons

Giganzo · Giganzo · commit 1b6af3acd380 · 2024-09-05T12:06:29.000+02:00
diff --git a/editor/plugins/node_3d_editor_plugin.cpp b/editor/plugins/node_3d_editor_plugin.cpp
@@ -7847,6 +7847,9 @@ void Node3DEditor::_sun_environ_settings_pressed() {
 	sun_environ_popup->set_position(pos - Vector2(sun_environ_popup->get_contents_minimum_size().width / 2, 0));
 	sun_environ_popup->reset_size();
 	sun_environ_popup->popup();
+	// Grabbing the focus is required for Shift modifier checking to be functional
+	// (when the Add sun/environment buttons are pressed).
+	sun_environ_popup->grab_focus();
 }
 
 void Node3DEditor::_add_sun_to_scene(bool p_already_added_environment) {

Original file line number	Diff line number	Diff line change
`@@ -7847,6 +7847,9 @@ void Node3DEditor::_sun_environ_settings_pressed() {`
`7847`	`7847`	`sun_environ_popup->set_position(pos - Vector2(sun_environ_popup->get_contents_minimum_size().width / 2, 0));`
`7848`	`7848`	`sun_environ_popup->reset_size();`
`7849`	`7849`	`sun_environ_popup->popup();`
	`7850`	`+ // Grabbing the focus is required for Shift modifier checking to be functional`
	`7851`	`+ // (when the Add sun/environment buttons are pressed).`
	`7852`	`+ sun_environ_popup->grab_focus();`
`7850`	`7853`	`}`
`7851`	`7854`
`7852`	`7855`	`void Node3DEditor::_add_sun_to_scene(bool p_already_added_environment) {`