Correctly update TileMapLayer highlighting when disabling it

groud · groud · commit 256a6713f22d · 2024-04-04T15:25:42.000+02:00
diff --git a/editor/plugins/tiles/tile_map_layer_editor.cpp b/editor/plugins/tiles/tile_map_layer_editor.cpp
@@ -3883,7 +3883,11 @@ void TileMapLayerEditor::_highlight_selected_layer_button_toggled(bool p_pressed
 	}
 
 	EditorSettings::get_singleton()->set("editors/tiles_editor/highlight_selected_layer", p_pressed);
-	_update_all_layers_highlighting();
+	if (p_pressed) {
+		_update_all_layers_highlighting();
+	} else {
+		_clear_all_layers_highlighting();
+	}
 }
 
 void TileMapLayerEditor::_advanced_menu_button_id_pressed(int p_id) {

Original file line number	Diff line number	Diff line change
`@@ -3883,7 +3883,11 @@ void TileMapLayerEditor::_highlight_selected_layer_button_toggled(bool p_pressed`
`3883`	`3883`	`}`
`3884`	`3884`
`3885`	`3885`	`EditorSettings::get_singleton()->set("editors/tiles_editor/highlight_selected_layer", p_pressed);`
`3886`		`- _update_all_layers_highlighting();`
	`3886`	`+ if (p_pressed) {`
	`3887`	`+ _update_all_layers_highlighting();`
	`3888`	`+ } else {`
	`3889`	`+ _clear_all_layers_highlighting();`
	`3890`	`+ }`
`3887`	`3891`	`}`
`3888`	`3892`
`3889`	`3893`	`void TileMapLayerEditor::_advanced_menu_button_id_pressed(int p_id) {`