Merge pull request godotengine#96758 from RandomShaper/fix_the_shift_must_go_on

akien-mga · akien-mga · commit 27552a2f26ad · 2024-09-09T17:52:03.000+02:00
RenderingDevice: Fix uncapped mipmap sizes causing div-by-zero
diff --git a/servers/rendering/rendering_device.cpp b/servers/rendering/rendering_device.cpp
@@ -1641,8 +1641,8 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye
 			copy_region.texture_region_size.z = d;
 			command_buffer_texture_copy_regions_vector.push_back(copy_region);
 
-			w = (w >> 1);
-			h = (h >> 1);
+			w = MAX(1u, w >> 1);
+			h = MAX(1u, h >> 1);
 			d = MAX(1u, d >> 1);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1641,8 +1641,8 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye`
`1641`	`1641`	`copy_region.texture_region_size.z = d;`
`1642`	`1642`	`command_buffer_texture_copy_regions_vector.push_back(copy_region);`
`1643`	`1643`
`1644`		`- w = (w >> 1);`
`1645`		`- h = (h >> 1);`
	`1644`	`+ w = MAX(1u, w >> 1);`
	`1645`	`+ h = MAX(1u, h >> 1);`
`1646`	`1646`	`d = MAX(1u, d >> 1);`
`1647`	`1647`	`}`
`1648`	`1648`