Skip to content

Commit 3b2b015

Browse files
committed
Merge pull request godotengine#107475 from beicause/fix-global-shader-texture-uniform
Fix global shader texture uniform
2 parents e15770e + 7419e44 commit 3b2b015

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

drivers/gles3/storage/material_storage.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -872,10 +872,14 @@ void MaterialData::update_textures(const HashMap<StringName, Variant> &p_paramet
872872
E->value = global_textures_pass;
873873
}
874874

875-
if (v->override.get_type() == Variant::RID && ((RID)v->override).is_valid()) {
876-
textures.push_back(v->override);
877-
} else if (v->value.get_type() == Variant::RID && ((RID)v->value).is_valid()) {
878-
textures.push_back(v->value);
875+
RID override_rid = v->override;
876+
if (override_rid.is_valid()) {
877+
textures.push_back(override_rid);
878+
} else {
879+
RID value_rid = v->value;
880+
if (value_rid.is_valid()) {
881+
textures.push_back(value_rid);
882+
}
879883
}
880884
}
881885

servers/rendering/renderer_rd/storage_rd/material_storage.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -906,10 +906,14 @@ void MaterialStorage::MaterialData::update_textures(const HashMap<StringName, Va
906906
E->value = global_textures_pass;
907907
}
908908

909-
if (v->override.get_type() == Variant::RID && ((RID)v->override).is_valid()) {
910-
textures.push_back(v->override);
911-
} else if (v->value.get_type() == Variant::RID && ((RID)v->value).is_valid()) {
912-
textures.push_back(v->value);
909+
RID override_rid = v->override;
910+
if (override_rid.is_valid()) {
911+
textures.push_back(override_rid);
912+
} else {
913+
RID value_rid = v->value;
914+
if (value_rid.is_valid()) {
915+
textures.push_back(value_rid);
916+
}
913917
}
914918
}
915919

0 commit comments

Comments
 (0)