Merge pull request godotengine#104693 from mihe/local-vector-move

akien-mga · akien-mga · commit 4a31936bc1af · 2025-03-28T14:34:49.000+01:00
Optimize `LocalVector::push_back` for non-trivial objects
diff --git a/core/templates/local_vector.h b/core/templates/local_vector.h
@@ -64,7 +64,7 @@ class LocalVector {
 		}
 
 		if constexpr (!std::is_trivially_constructible_v<T> && !force_trivial) {
-			memnew_placement(&data[count++], T(p_elem));
+			memnew_placement(&data[count++], T(std::move(p_elem)));
 		} else {
 			data[count++] = std::move(p_elem);
 		}

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ class LocalVector {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`if constexpr (!std::is_trivially_constructible_v<T> && !force_trivial) {`
`67`		`- memnew_placement(&data[count++], T(p_elem));`
	`67`	`+ memnew_placement(&data[count++], T(std::move(p_elem)));`
`68`	`68`	`} else {`
`69`	`69`	`data[count++] = std::move(p_elem);`
`70`	`70`	`}`