Merge pull request godotengine#101431 from YYF233333/remote_tree_fix

akien-mga · akien-mga · commit 5877f94b6512 · 2025-01-13T20:22:19.000+01:00
Use `GetFileAttributesW` for checking file existence on Windows
diff --git a/drivers/windows/file_access_windows.cpp b/drivers/windows/file_access_windows.cpp
@@ -402,13 +402,8 @@ bool FileAccessWindows::file_exists(const String &p_name) {
 	}
 
 	String filename = fix_path(p_name);
-	FILE *g = _wfsopen((LPCWSTR)(filename.utf16().get_data()), L"rb", _SH_DENYNO);
-	if (g == nullptr) {
-		return false;
-	} else {
-		fclose(g);
-		return true;
-	}
+	DWORD file_attr = GetFileAttributesW((LPCWSTR)(filename.utf16().get_data()));
+	return (file_attr != INVALID_FILE_ATTRIBUTES) && !(file_attr & FILE_ATTRIBUTE_DIRECTORY);
 }
 
 uint64_t FileAccessWindows::_get_modified_time(const String &p_file) {

Original file line number	Diff line number	Diff line change
`@@ -402,13 +402,8 @@ bool FileAccessWindows::file_exists(const String &p_name) {`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`String filename = fix_path(p_name);`
`405`		`- FILE *g = _wfsopen((LPCWSTR)(filename.utf16().get_data()), L"rb", _SH_DENYNO);`
`406`		`- if (g == nullptr) {`
`407`		`- return false;`
`408`		`- } else {`
`409`		`- fclose(g);`
`410`		`- return true;`
`411`		`- }`
	`405`	`+ DWORD file_attr = GetFileAttributesW((LPCWSTR)(filename.utf16().get_data()));`
	`406`	`+ return (file_attr != INVALID_FILE_ATTRIBUTES) && !(file_attr & FILE_ATTRIBUTE_DIRECTORY);`
`412`	`407`	`}`
`413`	`408`
`414`	`409`	`uint64_t FileAccessWindows::_get_modified_time(const String &p_file) {`