Merge pull request godotengine#89843 from kleonc/csharp-transform3d-interpolate-with-first-scale-then-rotate

akien-mga · akien-mga · commit 60d37f1d49c8 · 2024-03-26T13:45:39.000+01:00
[C#] Fix `Transform3D.InterpolateWith` applying rotation before scale
diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/Basis.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/Basis.cs
@@ -212,7 +212,7 @@ internal void SetQuaternionScale(Quaternion quaternion, Vector3 scale)
 
         private void Rotate(Quaternion quaternion)
         {
-            this *= new Basis(quaternion);
+            this = new Basis(quaternion) * this;
         }
 
         private void SetDiagonal(Vector3 diagonal)

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ internal void SetQuaternionScale(Quaternion quaternion, Vector3 scale)`
`212`	`212`
`213`	`213`	`private void Rotate(Quaternion quaternion)`
`214`	`214`	`{`
`215`		`- this *= new Basis(quaternion);`
	`215`	`+ this = new Basis(quaternion) * this;`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`private void SetDiagonal(Vector3 diagonal)`