Merge pull request godotengine#90874 from Zylann/fix_graph_frame_crash

akien-mga · akien-mga · commit 626c6a0ff877 · 2024-04-19T16:28:24.000+02:00
Fix crash when GraphFrame `sb_to_draw_panel` is not a StyleBoxFlat
diff --git a/scene/gui/graph_frame.cpp b/scene/gui/graph_frame.cpp
@@ -118,7 +118,7 @@ void GraphFrame::_notification(int p_what) {
 					sb_panel_flat->set_border_color(selected ? original_border_color : tint_color.lightened(0.3));
 					draw_style_box(sb_panel_flat, body_rect);
 				} else if (sb_panel_texture.is_valid()) {
-					sb_panel_texture = sb_panel_flat->duplicate();
+					sb_panel_texture = sb_panel_texture->duplicate();
 					sb_panel_texture->set_modulate(tint_color);
 					draw_style_box(sb_panel_texture, body_rect);
 				}

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ void GraphFrame::_notification(int p_what) {`
`118`	`118`	`sb_panel_flat->set_border_color(selected ? original_border_color : tint_color.lightened(0.3));`
`119`	`119`	`draw_style_box(sb_panel_flat, body_rect);`
`120`	`120`	`} else if (sb_panel_texture.is_valid()) {`
`121`		`- sb_panel_texture = sb_panel_flat->duplicate();`
	`121`	`+ sb_panel_texture = sb_panel_texture->duplicate();`
`122`	`122`	`sb_panel_texture->set_modulate(tint_color);`
`123`	`123`	`draw_style_box(sb_panel_texture, body_rect);`
`124`	`124`	`}`