Skip to content

Commit 66cf38e

Browse files
committed
Tests: Remove NavigationRegion3D race condition that fails on CI
As the comment pointed it out, it's a race condition, and evidently no, "it's [not] fine" ;)
1 parent 029aade commit 66cf38e

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

tests/scene/test_navigation_region_3d.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,6 @@ TEST_SUITE("[Navigation]") {
7171
CHECK_NE(navigation_mesh->get_vertices().size(), 0);
7272
}
7373

74-
// Race condition is present in the below subcase, but baking should take many
75-
// orders of magnitude longer than basic checks on the main thread, so it's fine.
76-
SUBCASE("Asynchronous bake should not be immediate") {
77-
navigation_region->bake_navigation_mesh(true);
78-
CHECK(navigation_region->is_baking());
79-
CHECK_EQ(navigation_mesh->get_polygon_count(), 0);
80-
CHECK_EQ(navigation_mesh->get_vertices().size(), 0);
81-
}
82-
8374
memdelete(mesh_instance);
8475
memdelete(navigation_region);
8576
memdelete(node_3d);

0 commit comments

Comments
 (0)