Merge pull request godotengine#94162 from anniryynanen/sprite-frames-crash

akien-mga · akien-mga · commit 685413a9489f · 2024-07-11T00:27:47.000+02:00
Fix edited node being removed before editor plugin handles focus loss
diff --git a/editor/plugins/canvas_item_editor_plugin.cpp b/editor/plugins/canvas_item_editor_plugin.cpp
@@ -772,7 +772,6 @@ bool CanvasItemEditor::_select_click_on_item(CanvasItem *item, Point2 p_click_po
 			// Reselect
 			if (Engine::get_singleton()->is_editor_hint()) {
 				selected_from_canvas = true;
-				EditorNode::get_singleton()->edit_node(item);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,6 @@ bool CanvasItemEditor::_select_click_on_item(CanvasItem *item, Point2 p_click_po`
`772`	`772`	`// Reselect`
`773`	`773`	`if (Engine::get_singleton()->is_editor_hint()) {`
`774`	`774`	`selected_from_canvas = true;`
`775`		`- EditorNode::get_singleton()->edit_node(item);`
`776`	`775`	`}`
`777`	`776`	`}`
`778`	`777`	`}`