Merge pull request godotengine#96464 from Faless/mp/fix_profiler_divsion_by_zero

akien-mga · akien-mga · commit 7c383767a299 · 2024-09-02T18:08:17.000+02:00
[MP] Fix division by zero in network profiler
diff --git a/modules/multiplayer/editor/editor_network_profiler.cpp b/modules/multiplayer/editor/editor_network_profiler.cpp
@@ -227,10 +227,10 @@ void EditorNetworkProfiler::add_sync_frame_data(const SyncInfo &p_frame) {
 		sync_data[p_frame.synchronizer].outgoing_syncs += p_frame.outgoing_syncs;
 	}
 	SyncInfo &info = sync_data[p_frame.synchronizer];
-	if (info.incoming_syncs) {
+	if (p_frame.incoming_syncs) {
 		info.incoming_size = p_frame.incoming_size / p_frame.incoming_syncs;
 	}
-	if (info.outgoing_syncs) {
+	if (p_frame.outgoing_syncs) {
 		info.outgoing_size = p_frame.outgoing_size / p_frame.outgoing_syncs;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -227,10 +227,10 @@ void EditorNetworkProfiler::add_sync_frame_data(const SyncInfo &p_frame) {`
`227`	`227`	`sync_data[p_frame.synchronizer].outgoing_syncs += p_frame.outgoing_syncs;`
`228`	`228`	`}`
`229`	`229`	`SyncInfo &info = sync_data[p_frame.synchronizer];`
`230`		`- if (info.incoming_syncs) {`
	`230`	`+ if (p_frame.incoming_syncs) {`
`231`	`231`	`info.incoming_size = p_frame.incoming_size / p_frame.incoming_syncs;`
`232`	`232`	`}`
`233`		`- if (info.outgoing_syncs) {`
	`233`	`+ if (p_frame.outgoing_syncs) {`
`234`	`234`	`info.outgoing_size = p_frame.outgoing_size / p_frame.outgoing_syncs;`
`235`	`235`	`}`
`236`	`236`	`}`