Merge pull request godotengine#102444 from ryevdokimov/save-confirmation-don't-reparent-to-self

Repiteo · Repiteo · commit 82759388d493 · 2025-02-05T10:27:29.000-06:00
Prevent save confirmation dialog from trying to parent to itself
diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp
@@ -5734,7 +5734,9 @@ void EditorNode::_cancel_close_scene_tab() {
 }
 
 void EditorNode::_prepare_save_confirmation_popup() {
-	save_confirmation->reparent(get_last_exclusive_window());
+	if (save_confirmation->get_window() != get_last_exclusive_window()) {
+		save_confirmation->reparent(get_last_exclusive_window());
+	}
 }
 
 void EditorNode::_toggle_distraction_free_mode() {

Original file line number	Diff line number	Diff line change
`@@ -5734,7 +5734,9 @@ void EditorNode::_cancel_close_scene_tab() {`
`5734`	`5734`	`}`
`5735`	`5735`
`5736`	`5736`	`void EditorNode::_prepare_save_confirmation_popup() {`
`5737`		`- save_confirmation->reparent(get_last_exclusive_window());`
	`5737`	`+ if (save_confirmation->get_window() != get_last_exclusive_window()) {`
	`5738`	`+ save_confirmation->reparent(get_last_exclusive_window());`
	`5739`	`+ }`
`5738`	`5740`	`}`
`5739`	`5741`
`5740`	`5742`	`void EditorNode::_toggle_distraction_free_mode() {`