Move the script reload function to outside the

lock to prevent worker threads from the
ResourceLoader::load method from causing a
deadlock

Author: preslavnpetrov

modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/ScriptManagerBridge.cs

@@ -493,6 +493,8 @@ private static unsafe void GetOrCreateScriptBridgeForType(Type scriptType, godot
             {
                 _scriptTypeBiMap.ReadWriteLock.ExitUpgradeableReadLock();
             }
+
+            NativeFuncs.godotsharp_internal_reload_registered_script(outScript->Reference);
         }
 
         internal static unsafe void GetOrLoadOrCreateScriptForType(Type scriptType, godot_ref* outScript)
@@ -527,12 +529,14 @@ static bool GetPathOtherwiseGetOrCreateScript(Type scriptType, godot_ref* outScr
 
                     CreateScriptBridgeForType(scriptType, outScript);
                     scriptPath = null;
-                    return false;
                 }
                 finally
                 {
                     _scriptTypeBiMap.ReadWriteLock.ExitUpgradeableReadLock();
                 }
+
+                NativeFuncs.godotsharp_internal_reload_registered_script(outScript->Reference);
+                return false;
             }
 
             static string GetVirtualConstructedGenericTypeScriptPath(Type scriptType, string scriptPath)
@@ -597,6 +601,9 @@ static string GetVirtualConstructedGenericTypeScriptPath(Type scriptType, string
             }
         }
 
+        /// <summary>
+        /// WARNING: We need to make sure that after unlocking the bimap, we call godotsharp_internal_reload_registered_script
+        /// </summary>
         private static unsafe void CreateScriptBridgeForType(Type scriptType, godot_ref* outScript)
         {
             Debug.Assert(!scriptType.IsGenericTypeDefinition, $"Script type must be a constructed generic type or not generic at all. Type: {scriptType}.");
@@ -613,8 +620,6 @@ private static unsafe void CreateScriptBridgeForType(Type scriptType, godot_ref*
             {
                 _scriptTypeBiMap.ReadWriteLock.ExitWriteLock();
             }
-
-            NativeFuncs.godotsharp_internal_reload_registered_script(outScript->Reference);
         }
 
         [UnmanagedCallersOnly]