Merge pull request godotengine#90035 from KoBeWi/SUPER_CALL_DEFERRED

akien-mga · akien-mga · commit 9b0b7afe287f · 2024-04-14T14:39:07.000+02:00
Fix scroll to description
diff --git a/editor/editor_help.cpp b/editor/editor_help.cpp
@@ -2324,7 +2324,8 @@ void EditorHelp::_help_callback(const String &p_topic) {
 	}
 
 	if (class_desc->is_ready()) {
-		callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).call_deferred(line);
+		// call_deferred() is not enough.
+		class_desc->connect("draw", callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).bind(line), CONNECT_ONE_SHOT | CONNECT_DEFERRED);
 	} else {
 		scroll_to = line;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2324,7 +2324,8 @@ void EditorHelp::_help_callback(const String &p_topic) {`
`2324`	`2324`	`}`
`2325`	`2325`
`2326`	`2326`	`if (class_desc->is_ready()) {`
`2327`		`- callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).call_deferred(line);`
	`2327`	`+ // call_deferred() is not enough.`
	`2328`	`+ class_desc->connect("draw", callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).bind(line), CONNECT_ONE_SHOT \| CONNECT_DEFERRED);`
`2328`	`2329`	`} else {`
`2329`	`2330`	`scroll_to = line;`
`2330`	`2331`	`}`