Replace find with contains/has where applicable

* Replaces `find(...) != -1` with `contains` for `String`
* Replaces `find(...) == -1` with `!contains` for `String`
* Replaces `find(...) != -1` with `has` for containers
* Replaces `find(...) == -1` with `!has` for containers

Author: AThousandShips

core/debugger/engine_debugger.cpp

@@ -137,7 +137,7 @@ void EngineDebugger::initialize(const String &p_uri, bool p_skip_breakpoints, co
 		script_debugger = memnew(ScriptDebugger);
 		// Tell the OS that we want to handle termination signals.
 		OS::get_singleton()->initialize_debugging();
-	} else if (p_uri.find("://") >= 0) {
+	} else if (p_uri.contains("://")) {
 		const String proto = p_uri.substr(0, p_uri.find("://") + 3);
 		if (!protocols.has(proto)) {
 			return;

core/extension/extension_api_dump.cpp

@@ -1201,7 +1201,7 @@ Dictionary GDExtensionAPIDump::generate_extension_api(bool p_include_docs) {
 					if (F.name.begins_with("_")) {
 						continue; //hidden property
 					}
-					if (F.name.find("/") >= 0) {
+					if (F.name.contains("/")) {
 						// Ignore properties with '/' (slash) in the name. These are only meant for use in the inspector.
 						continue;
 					}

core/io/ip_address.cpp

@@ -202,7 +202,7 @@ IPAddress::IPAddress(const String &p_string) {
 		// Wildcard (not a valid IP)
 		wildcard = true;
 
-	} else if (p_string.find(":") >= 0) {
+	} else if (p_string.contains(":")) {
 		// IPv6
 		_parse_ipv6(p_string);
 		valid = true;

core/string/ustring.cpp

@@ -3964,7 +3964,7 @@ String String::format(const Variant &values, const String &placeholder) const {
 				Variant v_val = values_arr[i];
 				String val = v_val;
 
-				if (placeholder.find("_") > -1) {
+				if (placeholder.contains("_")) {
 					new_string = new_string.replace(placeholder.replace("_", i_as_str), val);
 				} else {
 					new_string = new_string.replace_first(placeholder, val);

drivers/alsa/audio_driver_alsa.cpp

@@ -52,7 +52,7 @@ Error AudioDriverALSA::init_output_device() {
 	// If there is a specified output device check that it is really present
 	if (output_device_name != "Default") {
 		PackedStringArray list = get_output_device_list();
-		if (list.find(output_device_name) == -1) {
+		if (!list.has(output_device_name)) {
 			output_device_name = "Default";
 			new_output_device = "Default";
 		}

drivers/egl/egl_manager.cpp

@@ -383,7 +383,7 @@ Error EGLManager::initialize() {
 	ERR_FAIL_COND_V(eglGetError() != EGL_SUCCESS, ERR_BUG);
 
 	const char *platform = _get_platform_extension_name();
-	if (extensions_string.split(" ").find(platform) < 0) {
+	if (!extensions_string.split(" ").has(platform)) {
 		ERR_FAIL_V_MSG(ERR_UNAVAILABLE, vformat("EGL platform extension \"%s\" not found.", platform));
 	}
 

drivers/pulseaudio/audio_driver_pulseaudio.cpp

@@ -183,7 +183,7 @@ Error AudioDriverPulseAudio::init_output_device() {
 	// If there is a specified output device, check that it is really present
 	if (output_device_name != "Default") {
 		PackedStringArray list = get_output_device_list();
-		if (list.find(output_device_name) == -1) {
+		if (!list.has(output_device_name)) {
 			output_device_name = "Default";
 			new_output_device = "Default";
 		}
@@ -695,7 +695,7 @@ Error AudioDriverPulseAudio::init_input_device() {
 	// If there is a specified input device, check that it is really present
 	if (input_device_name != "Default") {
 		PackedStringArray list = get_input_device_list();
-		if (list.find(input_device_name) == -1) {
+		if (!list.has(input_device_name)) {
 			input_device_name = "Default";
 			new_input_device = "Default";
 		}

editor/create_dialog.cpp

@@ -376,7 +376,7 @@ float CreateDialog::_score_type(const String &p_type, const String &p_search) co
 	score *= _is_type_preferred(p_type) ? 1.0f : 0.9f;
 
 	// Add score for being a favorite type.
-	score *= (favorite_list.find(p_type) > -1) ? 1.0f : 0.8f;
+	score *= favorite_list.has(p_type) ? 1.0f : 0.8f;
 
 	// Look through at most 5 recent items
 	bool in_recent = false;

editor/debugger/debug_adapter/debug_adapter_parser.cpp

@@ -358,7 +358,7 @@ Dictionary DebugAdapterParser::req_setBreakpoints(const Dictionary &p_params) co
 	}
 
 	// If path contains \, it's a Windows path, so we need to convert it to /, and make the drive letter uppercase
-	if (source.path.find("\\") != -1) {
+	if (source.path.contains("\\")) {
 		source.path = source.path.replace("\\", "/");
 		source.path = source.path.substr(0, 1).to_upper() + source.path.substr(1);
 	}

editor/debugger/editor_debugger_node.cpp

@@ -262,7 +262,7 @@ void EditorDebuggerNode::set_keep_open(bool p_keep_open) {
 }
 
 Error EditorDebuggerNode::start(const String &p_uri) {
-	ERR_FAIL_COND_V(p_uri.find("://") < 0, ERR_INVALID_PARAMETER);
+	ERR_FAIL_COND_V(!p_uri.contains("://"), ERR_INVALID_PARAMETER);
 	if (keep_open && current_uri == p_uri && server.is_valid()) {
 		return OK;
 	}