Skip to content

Commit a627ee6

Browse files
committed
Merge pull request godotengine#112471 from Rudra-ravi/claude/fix-godot-official-issues-011CUrnHud9iQ4LV6FDv2hG7
Fix glow visual compatibility regression
2 parents 9eaa705 + 802eb0b commit a627ee6

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

doc/classes/Environment.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
<member name="glow_hdr_scale" type="float" setter="set_glow_hdr_bleed_scale" getter="get_glow_hdr_bleed_scale" default="2.0">
144144
The bleed scale of the HDR glow.
145145
</member>
146-
<member name="glow_hdr_threshold" type="float" setter="set_glow_hdr_bleed_threshold" getter="get_glow_hdr_bleed_threshold" default="0.0">
146+
<member name="glow_hdr_threshold" type="float" setter="set_glow_hdr_bleed_threshold" getter="get_glow_hdr_bleed_threshold" default="1.0">
147147
The lower threshold of the HDR glow. When using the Mobile rendering method (which only supports a lower dynamic range up to [code]2.0[/code]), this may need to be below [code]1.0[/code] for glow to be visible. A value of [code]0.9[/code] works well in this case. This value also needs to be decreased below [code]1.0[/code] when using glow in 2D, as 2D rendering is performed in SDR.
148148
</member>
149149
<member name="glow_intensity" type="float" setter="set_glow_intensity" getter="get_glow_intensity" default="0.3">

drivers/gles3/effects/glow.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class Glow {
4949

5050
float glow_intensity = 1.0;
5151
float glow_bloom = 0.0;
52-
float glow_hdr_bleed_threshold = 0.0;
52+
float glow_hdr_bleed_threshold = 1.0;
5353
float glow_hdr_bleed_scale = 2.0;
5454
float glow_hdr_luminance_cap = 12.0;
5555

drivers/gles3/rasterizer_scene_gles3.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2829,7 +2829,7 @@ void RasterizerSceneGLES3::_render_post_processing(const RenderDataGLES3 *p_rend
28292829
bool glow_enabled = false;
28302830
float glow_intensity = 1.0;
28312831
float glow_bloom = 0.0;
2832-
float glow_hdr_bleed_threshold = 0.0;
2832+
float glow_hdr_bleed_threshold = 1.0;
28332833
float glow_hdr_bleed_scale = 2.0;
28342834
float glow_hdr_luminance_cap = 12.0;
28352835
float srgb_white = 1.0;

scene/resources/environment.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ class Environment : public Resource {
168168
float glow_mix = 0.05;
169169
float glow_bloom = 0.0;
170170
GlowBlendMode glow_blend_mode = GLOW_BLEND_MODE_SCREEN;
171-
float glow_hdr_bleed_threshold = 0.0;
171+
float glow_hdr_bleed_threshold = 1.0;
172172
float glow_hdr_bleed_scale = 2.0;
173173
float glow_hdr_luminance_cap = 12.0;
174174
float glow_map_strength = 0.8f;

servers/rendering/storage/environment_storage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ class RendererEnvironmentStorage {
103103
float glow_bloom = 0.0;
104104
float glow_mix = 0.01;
105105
RS::EnvironmentGlowBlendMode glow_blend_mode = RS::ENV_GLOW_BLEND_MODE_SCREEN;
106-
float glow_hdr_bleed_threshold = 0.0;
106+
float glow_hdr_bleed_threshold = 1.0;
107107
float glow_hdr_luminance_cap = 12.0;
108108
float glow_hdr_bleed_scale = 2.0;
109109
float glow_map_strength = 0.0f; // 1.0f in GLES3 ??

0 commit comments

Comments
 (0)