Skip to content

Commit ad2039f

Browse files
committed
Make open project settings method have default empty string values
1 parent d285271 commit ad2039f

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

doc/classes/EditorInterface.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,10 @@
301301
</method>
302302
<method name="open_project_settings">
303303
<return type="void" />
304-
<param index="0" name="general_page" type="String" />
305-
<param index="1" name="filter" type="String" />
304+
<param index="0" name="general_page" type="String" default="&quot;&quot;" />
305+
<param index="1" name="filter" type="String" default="&quot;&quot;" />
306306
<description>
307-
Opens the project settings window at the specified [param general_page], with an optional [param filter] applied.
307+
Opens the project settings window at the optionally specified [param general_page], with an optional [param filter] applied.
308308
</description>
309309
</method>
310310
<method name="open_scene_from_path">

editor/editor_interface.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,14 @@ EditorUndoRedoManager *EditorInterface::get_editor_undo_redo() const {
112112

113113
void EditorInterface::open_project_settings(const String &p_general_page, const String &p_filter) {
114114
ProjectSettingsEditor *project_settings = EditorNode::get_singleton()->get_project_settings();
115-
project_settings->set_general_page(p_general_page);
116-
project_settings->set_filter(p_filter);
115+
116+
if (!p_general_page.is_empty()) {
117+
project_settings->set_general_page(p_general_page);
118+
}
119+
if (!p_filter.is_empty()) {
120+
project_settings->set_filter(p_filter);
121+
}
122+
117123
project_settings->popup_project_settings(false);
118124
}
119125

@@ -854,7 +860,7 @@ void EditorInterface::_bind_methods() {
854860
ClassDB::bind_method(D_METHOD("get_editor_toaster"), &EditorInterface::get_editor_toaster);
855861
ClassDB::bind_method(D_METHOD("get_editor_undo_redo"), &EditorInterface::get_editor_undo_redo);
856862

857-
ClassDB::bind_method(D_METHOD("open_project_settings", "general_page", "filter"), &EditorInterface::open_project_settings);
863+
ClassDB::bind_method(D_METHOD("open_project_settings", "general_page", "filter"), &EditorInterface::open_project_settings, DEFVAL(""), DEFVAL(""));
858864
ClassDB::bind_method(D_METHOD("open_export_dialog"), &EditorInterface::open_export_dialog);
859865
ClassDB::bind_method(D_METHOD("search_asset_library", "filter"), &EditorInterface::search_asset_library);
860866

editor/editor_interface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ class EditorInterface : public Object {
147147
String get_current_feature_profile() const;
148148
void set_current_feature_profile(const String &p_profile_name);
149149

150-
void open_project_settings(const String &p_general_page, const String &p_filter);
150+
void open_project_settings(const String &p_general_page = "", const String &p_filter = "");
151151
void open_export_dialog();
152152
void search_asset_library(const String &p_filter);
153153

0 commit comments

Comments
 (0)