Commit b5591bf
committed
change AsSpan to use a range from "from" to "end"
the current code assumes that float.Parse behaves the same as the
internal C++ code, however without using "end" as part of the span, it
will parse from index 0 to the end of the string, ignoring commas. for
example, this causes it to parse "0,5,0" with divisor "," as [50, 50,
0], as the float.Parse method ignores commas in floats.
if another divisor is used, it throws a System.FormatException due to
containing invalid characters, as it fails to account for the position
of the divisor for the span.1 parent 68410ac commit b5591bf
File tree
1 file changed
+1
-1
lines changed- modules/mono/glue/GodotSharp/GodotSharp/Core
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1539 | 1539 | | |
1540 | 1540 | | |
1541 | 1541 | | |
1542 | | - | |
| 1542 | + | |
1543 | 1543 | | |
1544 | 1544 | | |
1545 | 1545 | | |
| |||
0 commit comments