Skip to content

Commit d100888

Browse files
committed
Merge pull request godotengine#90208 from Repiteo/scons/ninja-msvc
SCons: Fix Ninja compilation with MSVC
2 parents ca2d286 + 7918d50 commit d100888

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ platform/windows/godot_res.res
3838
# Ninja build files
3939
build.ninja
4040
.ninja
41+
run_ninja_env.bat
4142

4243
# Generated by Godot binary
4344
.import/

core/crypto/SCsub

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ if is_builtin or not has_module:
2121
# to make a "light" build with only the necessary mbedtls files.
2222
if not has_module:
2323
# Minimal mbedTLS config file
24-
env_crypto.Append(
25-
CPPDEFINES=[("MBEDTLS_CONFIG_FILE", '\\"thirdparty/mbedtls/include/godot_core_mbedtls_config.h\\"')]
26-
)
24+
config_path = "thirdparty/mbedtls/include/godot_core_mbedtls_config.h"
25+
config_path = f"<{config_path}>" if env_crypto["ninja"] and env_crypto.msvc else f'\\"{config_path}\\"'
26+
env_crypto.Append(CPPDEFINES=[("MBEDTLS_CONFIG_FILE", config_path)])
2727
# Build minimal mbedTLS library (MD5/SHA/Base64/AES).
2828
env_thirdparty = env_crypto.Clone()
2929
env_thirdparty.disable_warnings()
@@ -46,9 +46,9 @@ if not has_module:
4646
env.core_sources += thirdparty_obj
4747
elif is_builtin:
4848
# Module mbedTLS config file
49-
env_crypto.Append(
50-
CPPDEFINES=[("MBEDTLS_CONFIG_FILE", '\\"thirdparty/mbedtls/include/godot_module_mbedtls_config.h\\"')]
51-
)
49+
config_path = "thirdparty/mbedtls/include/godot_module_mbedtls_config.h"
50+
config_path = f"<{config_path}>" if env_crypto["ninja"] and env_crypto.msvc else f'\\"{config_path}\\"'
51+
env_crypto.Append(CPPDEFINES=[("MBEDTLS_CONFIG_FILE", config_path)])
5252
# Needed to force rebuilding the core files when the configuration file is updated.
5353
thirdparty_obj = ["#thirdparty/mbedtls/include/godot_module_mbedtls_config.h"]
5454

modules/mbedtls/SCsub

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ if env["builtin_mbedtls"]:
100100
thirdparty_sources = [thirdparty_dir + file for file in thirdparty_sources]
101101

102102
env_mbed_tls.Prepend(CPPPATH=["#thirdparty/mbedtls/include/"])
103-
env_mbed_tls.Append(
104-
CPPDEFINES=[("MBEDTLS_CONFIG_FILE", '\\"thirdparty/mbedtls/include/godot_module_mbedtls_config.h\\"')]
105-
)
103+
config_path = "thirdparty/mbedtls/include/godot_module_mbedtls_config.h"
104+
config_path = f"<{config_path}>" if env_mbed_tls["ninja"] and env_mbed_tls.msvc else f'\\"{config_path}\\"'
105+
env_mbed_tls.Append(CPPDEFINES=[("MBEDTLS_CONFIG_FILE", config_path)])
106106

107107
env_thirdparty = env_mbed_tls.Clone()
108108
env_thirdparty.disable_warnings()

0 commit comments

Comments
 (0)