Skip to content

Commit d4e78b8

Browse files
committed
Store GLES over GL status in the OS to avoid direct renderer includes in the editor.
1 parent 8120e03 commit d4e78b8

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

core/os/os.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ class OS {
7575
int _display_driver_id = -1;
7676
String _current_rendering_driver_name;
7777
String _current_rendering_method;
78+
bool _is_gles_over_gl = false;
7879

7980
RemoteFilesystemClient default_rfs;
8081

@@ -130,9 +131,11 @@ class OS {
130131

131132
void set_current_rendering_driver_name(const String &p_driver_name) { _current_rendering_driver_name = p_driver_name; }
132133
void set_current_rendering_method(const String &p_name) { _current_rendering_method = p_name; }
134+
void set_gles_over_gl(bool p_enabled) { _is_gles_over_gl = p_enabled; }
133135

134136
String get_current_rendering_driver_name() const { return _current_rendering_driver_name; }
135137
String get_current_rendering_method() const { return _current_rendering_method; }
138+
bool get_gles_over_gl() const { return _is_gles_over_gl; }
136139

137140
int get_display_driver_id() const { return _display_driver_id; }
138141

drivers/gles3/rasterizer_gles3.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ class RasterizerGLES3 : public RendererCompositor {
113113

114114
static void make_current(bool p_gles_over_gl) {
115115
gles_over_gl = p_gles_over_gl;
116+
OS::get_singleton()->set_gles_over_gl(gles_over_gl);
116117
_create_func = _create_current;
117118
low_end = true;
118119
}

editor/editor_node.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,6 @@
167167

168168
#include "modules/modules_enabled.gen.h" // For gdscript, mono.
169169

170-
#if defined(GLES3_ENABLED)
171-
#include "drivers/gles3/rasterizer_gles3.h"
172-
#endif
173-
174170
EditorNode *EditorNode::singleton = nullptr;
175171

176172
static const String EDITOR_NODE_CONFIG_SECTION = "EditorNode";
@@ -5062,18 +5058,16 @@ String EditorNode::_get_system_info() const {
50625058
driver_name = "Vulkan";
50635059
} else if (driver_name == "d3d12") {
50645060
driver_name = "Direct3D 12";
5065-
#if defined(GLES3_ENABLED)
50665061
} else if (driver_name == "opengl3_angle") {
50675062
driver_name = "OpenGL ES 3/ANGLE";
50685063
} else if (driver_name == "opengl3_es") {
50695064
driver_name = "OpenGL ES 3";
50705065
} else if (driver_name == "opengl3") {
5071-
if (RasterizerGLES3::is_gles_over_gl()) {
5066+
if (OS::get_singleton()->get_gles_over_gl()) {
50725067
driver_name = "OpenGL 3";
50735068
} else {
50745069
driver_name = "OpenGL ES 3";
50755070
}
5076-
#endif
50775071
} else if (driver_name == "metal") {
50785072
driver_name = "Metal";
50795073
}

0 commit comments

Comments
 (0)