Fix issue with moving maximized window in macOS

Jiali-Qiu · Jiali-Qiu · commit d78cb43ec205 · 2024-04-01T17:07:24.000+01:00
When opening the Godot editor and maximizing the window by double-clicking the title bar, users are unable to drag the window with the mouse. With this commit, `window_set_position` allows the maximized window to be moved by dragging it. Only the fullscreen window won't be allowed to move. Fixes godotengine#78758.
diff --git a/platform/macos/display_server_macos.mm b/platform/macos/display_server_macos.mm
@@ -1995,7 +1995,7 @@
 	ERR_FAIL_COND(!windows.has(p_window));
 	WindowData &wd = windows[p_window];
 
-	if (NSEqualRects([wd.window_object frame], [[wd.window_object screen] visibleFrame])) {
+	if (wd.fullscreen) {
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1995,7 +1995,7 @@`
`1995`	`1995`	`ERR_FAIL_COND(!windows.has(p_window));`
`1996`	`1996`	`WindowData &wd = windows[p_window];`
`1997`	`1997`
`1998`		`- if (NSEqualRects([wd.window_object frame], [[wd.window_object screen] visibleFrame])) {`
	`1998`	`+ if (wd.fullscreen) {`
`1999`	`1999`	`return;`
`2000`	`2000`	`}`
`2001`	`2001`