Skip to content

Commit e63b5ba

Browse files
committed
Merge pull request godotengine#91416 from Calinou/d3d12-sdk-update-install-script
Update dependencies in D3D12 SDK installer script
2 parents 51cb2df + 47ac224 commit e63b5ba

File tree

3 files changed

+35
-13
lines changed

3 files changed

+35
-13
lines changed

core/config/project_settings.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,7 +1556,11 @@ ProjectSettings::ProjectSettings() {
15561556
GLOBAL_DEF_RST("rendering/rendering_device/d3d12/max_misc_descriptors_per_frame", 512);
15571557
custom_prop_info["rendering/rendering_device/d3d12/max_misc_descriptors_per_frame"] = PropertyInfo(Variant::INT, "rendering/rendering_device/d3d12/max_misc_descriptors_per_frame", PROPERTY_HINT_RANGE, "32,4096");
15581558

1559-
GLOBAL_DEF_RST(PropertyInfo(Variant::INT, "rendering/rendering_device/d3d12/agility_sdk_version"), 610);
1559+
// The default value must match the minor part of the Agility SDK version
1560+
// installed by the scripts provided in the repository
1561+
// (check `misc/scripts/install_d3d12_sdk_windows.py`).
1562+
// For example, if the script installs 1.613.3, the default value must be 613.
1563+
GLOBAL_DEF_RST(PropertyInfo(Variant::INT, "rendering/rendering_device/d3d12/agility_sdk_version"), 613);
15601564

15611565
GLOBAL_DEF_BASIC(PropertyInfo(Variant::INT, "rendering/textures/canvas_textures/default_texture_filter", PROPERTY_HINT_ENUM, "Nearest,Linear,Linear Mipmap,Nearest Mipmap"), 1);
15621566
GLOBAL_DEF_BASIC(PropertyInfo(Variant::INT, "rendering/textures/canvas_textures/default_texture_repeat", PROPERTY_HINT_ENUM, "Disable,Enable,Mirror"), 0);

doc/classes/ProjectSettings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2713,8 +2713,8 @@
27132713
<member name="rendering/renderer/rendering_method.web" type="String" setter="" getter="" default="&quot;gl_compatibility&quot;">
27142714
Override for [member rendering/renderer/rendering_method] on web.
27152715
</member>
2716-
<member name="rendering/rendering_device/d3d12/agility_sdk_version" type="int" setter="" getter="" default="610">
2717-
Version code of the Direct3D 12 Agility SDK to use ([code]D3D12SDKVersion[/code]).
2716+
<member name="rendering/rendering_device/d3d12/agility_sdk_version" type="int" setter="" getter="" default="613">
2717+
Version code of the [url=https://devblogs.microsoft.com/directx/directx12agility/]Direct3D 12 Agility SDK[/url] to use ([code]D3D12SDKVersion[/code]). This must match the [i]minor[/i] version that is installed next to the editor binary and in the export templates directory for the current editor version. For example, if you have [code]1.613.3[/code] installed, you need to input [code]613[/code] here.
27182718
</member>
27192719
<member name="rendering/rendering_device/d3d12/max_misc_descriptors_per_frame" type="int" setter="" getter="" default="512">
27202720
The number of entries in the miscellaneous descriptors heap the Direct3D 12 rendering driver uses each frame, used for various operations like clearing a texture.

misc/scripts/install_d3d12_sdk_windows.py

100644100755
Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,18 @@
44
import urllib.request
55
import shutil
66
import subprocess
7+
import sys
8+
9+
# Enable ANSI escape code support on Windows 10 and later (for colored console output).
10+
# <https://github.com/python/cpython/issues/73245>
11+
if sys.platform == "win32":
12+
from ctypes import windll, c_int, byref
13+
14+
stdout_handle = windll.kernel32.GetStdHandle(c_int(-11))
15+
mode = c_int(0)
16+
windll.kernel32.GetConsoleMode(c_int(stdout_handle), byref(mode))
17+
mode = c_int(mode.value | 4)
18+
windll.kernel32.SetConsoleMode(c_int(stdout_handle), mode)
719

820
# Base Godot dependencies path
921
# If cross-compiling (no LOCALAPPDATA), we install in `bin`
@@ -14,21 +26,27 @@
1426
deps_folder = os.path.join("bin", "build_deps")
1527

1628
# DirectX Shader Compiler
17-
dxc_version = "v1.7.2308"
18-
dxc_filename = "dxc_2023_08_14.zip"
29+
# Check for latest version: https://github.com/microsoft/DirectXShaderCompiler/releases/latest
30+
dxc_version = "v1.8.2403.2"
31+
dxc_filename = "dxc_2024_03_29.zip"
1932
dxc_archive = os.path.join(deps_folder, dxc_filename)
2033
dxc_folder = os.path.join(deps_folder, "dxc")
2134
# Mesa NIR
35+
# Check for latest version: https://github.com/godotengine/godot-nir-static/releases/latest
2236
mesa_version = "23.1.9"
2337
mesa_filename = "godot-nir-23.1.9.zip"
2438
mesa_archive = os.path.join(deps_folder, mesa_filename)
2539
mesa_folder = os.path.join(deps_folder, "mesa")
2640
# WinPixEventRuntime
27-
pix_version = "1.0.231030001"
41+
# Check for latest version: https://www.nuget.org/api/v2/package/WinPixEventRuntime (check downloaded filename)
42+
pix_version = "1.0.240308001"
2843
pix_archive = os.path.join(deps_folder, f"WinPixEventRuntime_{pix_version}.nupkg")
2944
pix_folder = os.path.join(deps_folder, "pix")
3045
# DirectX 12 Agility SDK
31-
agility_sdk_version = "1.610.4"
46+
# Check for latest version: https://www.nuget.org/api/v2/package/Microsoft.Direct3D.D3D12 (check downloaded filename)
47+
# After updating this, remember to change the default value of the `rendering/rendering_device/d3d12/agility_sdk_version`
48+
# project setting to match the minor version (e.g. for `1.613.3`, it should be `613`).
49+
agility_sdk_version = "1.613.3"
3250
agility_sdk_archive = os.path.join(deps_folder, f"Agility_SDK_{agility_sdk_version}.nupkg")
3351
agility_sdk_folder = os.path.join(deps_folder, "agility_sdk")
3452

@@ -37,7 +55,7 @@
3755
os.makedirs(deps_folder)
3856

3957
# DirectX Shader Compiler
40-
print("[1/4] DirectX Shader Compiler")
58+
print("\x1b[1m[1/4] DirectX Shader Compiler\x1b[0m")
4159
if os.path.isfile(dxc_archive):
4260
os.remove(dxc_archive)
4361
print(f"Downloading DirectX Shader Compiler {dxc_filename} ...")
@@ -54,7 +72,7 @@
5472
print(f"DirectX Shader Compiler {dxc_filename} installed successfully.\n")
5573

5674
# Mesa NIR
57-
print("[2/4] Mesa NIR")
75+
print("\x1b[1m[2/4] Mesa NIR\x1b[0m")
5876
if os.path.isfile(mesa_archive):
5977
os.remove(mesa_archive)
6078
print(f"Downloading Mesa NIR {mesa_filename} ...")
@@ -81,7 +99,7 @@
8199
dlltool = shutil.which("x86_64-w64-mingw32-dlltool") or ""
82100
has_mingw = gendef != "" and dlltool != ""
83101

84-
print("[3/4] WinPixEventRuntime")
102+
print("\x1b[1m[3/4] WinPixEventRuntime\x1b[0m")
85103
if os.path.isfile(pix_archive):
86104
os.remove(pix_archive)
87105
print(f"Downloading WinPixEventRuntime {pix_version} ...")
@@ -112,7 +130,7 @@
112130
print(f"WinPixEventRuntime {pix_version} installed successfully.\n")
113131

114132
# DirectX 12 Agility SDK
115-
print("[4/4] DirectX 12 Agility SDK")
133+
print("\x1b[1m[4/4] DirectX 12 Agility SDK\x1b[0m")
116134
if os.path.isfile(agility_sdk_archive):
117135
os.remove(agility_sdk_archive)
118136
print(f"Downloading DirectX 12 Agility SDK {agility_sdk_version} ...")
@@ -128,5 +146,5 @@
128146
print(f"DirectX 12 Agility SDK {agility_sdk_version} installed successfully.\n")
129147

130148
# Complete message
131-
print(f'All Direct3D 12 SDK components were installed to "{deps_folder}" successfully!')
132-
print('You can now build Godot with Direct3D 12 support enabled by running "scons d3d12=yes".')
149+
print(f'\x1b[92mAll Direct3D 12 SDK components were installed to "{deps_folder}" successfully!\x1b[0m')
150+
print('\x1b[92mYou can now build Godot with Direct3D 12 support enabled by running "scons d3d12=yes".\x1b[0m')

0 commit comments

Comments
 (0)