Skip to content

Commit e67e8b8

Browse files
committed
Merge pull request godotengine#100524 from BlueCube3310/ktx-etc
KTX: Add support for loading most ETC-compressed formats
2 parents 3394988 + 5608f65 commit e67e8b8

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

modules/ktx/texture_loader_ktx.cpp

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -208,32 +208,33 @@ static Ref<Image> load_from_file_access(Ref<FileAccess> f, Error *r_error) {
208208
case GL_COMPRESSED_RGBA_BPTC_UNORM:
209209
format = Image::FORMAT_BPTC_RGBA;
210210
break;
211-
#if 0 // TODO: ETC compression is bogus.
212211
case GL_ETC1_RGB8_OES:
213212
format = Image::FORMAT_ETC;
214213
break;
215214
case GL_COMPRESSED_R11_EAC:
216215
format = Image::FORMAT_ETC2_R11;
217216
break;
218-
case GL_COMPRESSED_SIGNED_R11_EAC:
217+
// Decompression is not supported for this format.
218+
/*case GL_COMPRESSED_SIGNED_R11_EAC:
219219
format = Image::FORMAT_ETC2_R11S;
220-
break;
220+
break;*/
221221
case GL_COMPRESSED_RG11_EAC:
222222
format = Image::FORMAT_ETC2_RG11;
223223
break;
224-
case GL_COMPRESSED_SIGNED_RG11_EAC:
224+
// Decompression is not supported for this format.
225+
/*case GL_COMPRESSED_SIGNED_RG11_EAC:
225226
format = Image::FORMAT_ETC2_RG11S;
226-
break;
227+
break;*/
227228
case GL_COMPRESSED_RGB8_ETC2:
228229
format = Image::FORMAT_ETC2_RGB8;
229230
break;
230231
case GL_COMPRESSED_RGBA8_ETC2_EAC:
231232
format = Image::FORMAT_ETC2_RGBA8;
232233
break;
233-
case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2:
234+
// Decompression is not supported for this format.
235+
/*case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_ETC2:
234236
format = Image::FORMAT_ETC2_RGB8A1;
235-
break;
236-
#endif
237+
break;*/
237238
case GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR:
238239
format = Image::FORMAT_ASTC_4x4;
239240
break;
@@ -406,29 +407,30 @@ static Ref<Image> load_from_file_access(Ref<FileAccess> f, Error *r_error) {
406407
case VK_FORMAT_BC7_UNORM_BLOCK:
407408
format = Image::FORMAT_BPTC_RGBA;
408409
break;
409-
#if 0 // TODO: ETC compression is bogus.
410410
case VK_FORMAT_EAC_R11_UNORM_BLOCK:
411411
format = Image::FORMAT_ETC2_R11;
412412
break;
413-
case VK_FORMAT_EAC_R11_SNORM_BLOCK:
413+
// Decompression is not supported for this format.
414+
/*case VK_FORMAT_EAC_R11_SNORM_BLOCK:
414415
format = Image::FORMAT_ETC2_R11S;
415-
break;
416+
break;*/
416417
case VK_FORMAT_EAC_R11G11_UNORM_BLOCK:
417418
format = Image::FORMAT_ETC2_RG11;
418419
break;
419-
case VK_FORMAT_EAC_R11G11_SNORM_BLOCK:
420+
// Decompression is not supported for this format.
421+
/*case VK_FORMAT_EAC_R11G11_SNORM_BLOCK:
420422
format = Image::FORMAT_ETC2_RG11S;
421-
break;
423+
break;*/
422424
case VK_FORMAT_ETC2_R8G8B8_UNORM_BLOCK:
423425
format = Image::FORMAT_ETC2_RGB8;
424426
break;
425427
case VK_FORMAT_ETC2_R8G8B8A8_UNORM_BLOCK:
426428
format = Image::FORMAT_ETC2_RGBA8;
427429
break;
428-
case VK_FORMAT_ETC2_R8G8B8A1_UNORM_BLOCK:
430+
// Decompression is not supported for this format.
431+
/*case VK_FORMAT_ETC2_R8G8B8A1_UNORM_BLOCK:
429432
format = Image::FORMAT_ETC2_RGB8A1;
430-
break;
431-
#endif
433+
break;*/
432434
case VK_FORMAT_ASTC_4x4_SRGB_BLOCK:
433435
format = Image::FORMAT_ASTC_4x4;
434436
break;

0 commit comments

Comments
 (0)