Merge pull request godotengine#90167 from ajreckof/fix-negative-value-for-position_smoothing_speed-being-allowed

akien-mga · akien-mga · commit fe784573c4a7 · 2024-04-05T12:16:14.000+02:00
Ensure `Camera2D.position_smoothing_speed` is non-negative.
diff --git a/scene/2d/camera_2d.cpp b/scene/2d/camera_2d.cpp
@@ -627,7 +627,7 @@ void Camera2D::align() {
 }
 
 void Camera2D::set_position_smoothing_speed(real_t p_speed) {
-	position_smoothing_speed = p_speed;
+	position_smoothing_speed = MAX(0, p_speed);
 	_update_process_internal_for_smoothing();
 }
 
@@ -636,7 +636,7 @@ real_t Camera2D::get_position_smoothing_speed() const {
 }
 
 void Camera2D::set_rotation_smoothing_speed(real_t p_speed) {
-	rotation_smoothing_speed = p_speed;
+	rotation_smoothing_speed = MAX(0, p_speed);
 	_update_process_internal_for_smoothing();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -627,7 +627,7 @@ void Camera2D::align() {`
`627`	`627`	`}`
`628`	`628`
`629`	`629`	`void Camera2D::set_position_smoothing_speed(real_t p_speed) {`
`630`		`- position_smoothing_speed = p_speed;`
	`630`	`+ position_smoothing_speed = MAX(0, p_speed);`
`631`	`631`	`_update_process_internal_for_smoothing();`
`632`	`632`	`}`
`633`	`633`
`@@ -636,7 +636,7 @@ real_t Camera2D::get_position_smoothing_speed() const {`
`636`	`636`	`}`
`637`	`637`
`638`	`638`	`void Camera2D::set_rotation_smoothing_speed(real_t p_speed) {`
`639`		`- rotation_smoothing_speed = p_speed;`
	`639`	`+ rotation_smoothing_speed = MAX(0, p_speed);`
`640`	`640`	`_update_process_internal_for_smoothing();`
`641`	`641`	`}`
`642`	`642`