Remove mention of ns/class customization, rename class

kzu · kzu · commit 45431da95c2d · 2024-11-12T15:48:54.000-03:00
Rename from AttributedServicesExtension > AddServicesNoReflectionExtension (since we don't do just attributes anymore). Fixes #119
diff --git a/readme.md b/readme.md
@@ -270,20 +270,6 @@ parameters), you can annotate it with `[ImportingConstructor]` from either NuGet
 or .NET MEF ([System.ComponentModel.Composition](https://www.nuget.org/packages/System.ComponentModel.Composition)).
 
 
-### Customize Generated Class
-
-You can customize the generated class namespace and name with the following 
-MSBuild properties:
-
-```xml
-<PropertyGroup>
-    <AddServicesNamespace>MyNamespace</AddServicesNamespace>
-    <AddServicesClassName>MyExtensions</AddServicesClassName>
-</PropertyGroup>
-```
-
-They default to `Microsoft.Extensions.DependencyInjection` and `AddServicesExtension` 
-respectively.
 
 <!-- include https://github.com/devlooped/sponsors/raw/main/footer.md -->
 # Sponsors 
diff --git a/src/CodeAnalysis.Tests/AddServicesAnalyzerTests.cs b/src/CodeAnalysis.Tests/AddServicesAnalyzerTests.cs
@@ -43,7 +43,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
@@ -89,7 +89,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
@@ -130,7 +130,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
@@ -177,7 +177,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
diff --git a/src/CodeAnalysis.Tests/ConventionAnalyzerTests.cs b/src/CodeAnalysis.Tests/ConventionAnalyzerTests.cs
@@ -42,7 +42,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
@@ -86,7 +86,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
@@ -133,7 +133,7 @@ public static void Main()
             {
                 Sources =
                 {
-                    ThisAssembly.Resources.AttributedServicesExtension.Text,
+                    ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,
                     ThisAssembly.Resources.ServiceAttribute.Text,
                     ThisAssembly.Resources.ServiceAttribute_1.Text,
                 },
diff --git a/src/DependencyInjection.Tests/ContentFiles.targets b/src/DependencyInjection.Tests/ContentFiles.targets
@@ -2,13 +2,13 @@
   <!-- Simulates including the files under contentFiles/cs/netstandard2.0 in the final package -->
 
   <ItemGroup>
-    <Compile Include="$(MSBuildThisFileDirectory)..\DependencyInjection\AttributedServicesExtension.cs" Link="AttributedServicesExtension.cs" Visible="false" />
+    <Compile Include="$(MSBuildThisFileDirectory)..\DependencyInjection\AddServicesNoReflectionExtension.cs" Link="AddServicesNoReflectionExtension.cs" Visible="false" />
     <Compile Include="$(MSBuildThisFileDirectory)..\DependencyInjection\ServiceAttribute.cs" Link="ServiceAttribute.cs" Visible="false" />
     <Compile Include="$(MSBuildThisFileDirectory)..\DependencyInjection\ServiceAttribute`1.cs" Link="ServiceAttribute`1.cs" Visible="false" />
   </ItemGroup>
 
   <ItemGroup>
-    <EmbeddedResource Include="$(MSBuildThisFileDirectory)..\DependencyInjection\AttributedServicesExtension.cs" Type="Non-Resx" />
+    <EmbeddedResource Include="$(MSBuildThisFileDirectory)..\DependencyInjection\AddServicesNoReflectionExtension.cs" Type="Non-Resx" />
     <EmbeddedResource Include="$(MSBuildThisFileDirectory)..\DependencyInjection\ServiceAttribute.cs" Type="Non-Resx" />
     <EmbeddedResource Include="$(MSBuildThisFileDirectory)..\DependencyInjection\ServiceAttribute`1.cs" Type="Non-Resx" />
   </ItemGroup>
diff --git a/src/DependencyInjection/AddServicesNoReflectionExtension.cs b/src/DependencyInjection/AddServicesNoReflectionExtension.cs
@@ -8,7 +8,7 @@ namespace Microsoft.Extensions.DependencyInjection
     /// compile-time discovered services to an <see cref="IServiceCollection"/>.
     /// </summary>
     [EditorBrowsable(EditorBrowsableState.Never)]
-    static partial class AttributedServicesExtension
+    static partial class AddServicesNoReflectionExtension
     {
         static readonly ServiceDescriptor servicesAddedDescriptor = new ServiceDescriptor(typeof(DDIAddServicesAttribute), _ => new DDIAddServicesAttribute(), ServiceLifetime.Singleton);
 
diff --git a/src/DependencyInjection/DependencyInjection.csproj b/src/DependencyInjection/DependencyInjection.csproj
@@ -25,7 +25,7 @@
   <ItemGroup>
     <None Update="Devlooped.Extensions.DependencyInjection.props" CopyToOutputDirectory="PreserveNewest" PackFolder="buildTransitive" />
     <None Update="Devlooped.Extensions.DependencyInjection.targets" CopyToOutputDirectory="PreserveNewest" PackFolder="buildTransitive" />
-    <Compile Update="AttributedServicesExtension.cs" Pack="true" />
+    <Compile Update="AddServicesNoReflectionExtension.cs" Pack="true" />
     <Compile Update="ServiceAttribute*.cs" Pack="true" />
   </ItemGroup>
 
diff --git a/src/DependencyInjection/IncrementalGenerator.cs b/src/DependencyInjection/IncrementalGenerator.cs
@@ -263,7 +263,7 @@ void AddPartial(string methodName, SourceProductionContext ctx, (ImmutableArray<
             
             namespace Microsoft.Extensions.DependencyInjection
             {
-                static partial class AttributedServicesExtension
+                static partial class AddServicesNoReflectionExtension
                 {
                     static partial void {{methodName}}Services(IServiceCollection services)
                     {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public static void Main()`
`43`	`43`	`{`
`44`	`44`	`Sources =`
`45`	`45`	`{`
`46`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`46`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`47`	`47`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`48`	`48`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`49`	`49`	`},`
`@@ -89,7 +89,7 @@ public static void Main()`
`89`	`89`	`{`
`90`	`90`	`Sources =`
`91`	`91`	`{`
`92`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`92`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`93`	`93`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`94`	`94`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`95`	`95`	`},`
`@@ -130,7 +130,7 @@ public static void Main()`
`130`	`130`	`{`
`131`	`131`	`Sources =`
`132`	`132`	`{`
`133`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`133`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`134`	`134`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`135`	`135`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`136`	`136`	`},`
`@@ -177,7 +177,7 @@ public static void Main()`
`177`	`177`	`{`
`178`	`178`	`Sources =`
`179`	`179`	`{`
`180`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`180`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`181`	`181`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`182`	`182`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`183`	`183`	`},`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public static void Main()`
`42`	`42`	`{`
`43`	`43`	`Sources =`
`44`	`44`	`{`
`45`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`45`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`46`	`46`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`47`	`47`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`48`	`48`	`},`
`@@ -86,7 +86,7 @@ public static void Main()`
`86`	`86`	`{`
`87`	`87`	`Sources =`
`88`	`88`	`{`
`89`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`89`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`90`	`90`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`91`	`91`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`92`	`92`	`},`
`@@ -133,7 +133,7 @@ public static void Main()`
`133`	`133`	`{`
`134`	`134`	`Sources =`
`135`	`135`	`{`
`136`		`- ThisAssembly.Resources.AttributedServicesExtension.Text,`
	`136`	`+ ThisAssembly.Resources.AddServicesNoReflectionExtension.Text,`
`137`	`137`	`ThisAssembly.Resources.ServiceAttribute.Text,`
`138`	`138`	`ThisAssembly.Resources.ServiceAttribute_1.Text,`
`139`	`139`	`},`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace Microsoft.Extensions.DependencyInjection`
`8`	`8`	`/// compile-time discovered services to an <see cref="IServiceCollection"/>.`
`9`	`9`	`/// </summary>`
`10`	`10`	`[EditorBrowsable(EditorBrowsableState.Never)]`
`11`		`- static partial class AttributedServicesExtension`
	`11`	`+ static partial class AddServicesNoReflectionExtension`
`12`	`12`	`{`
`13`	`13`	`static readonly ServiceDescriptor servicesAddedDescriptor = new ServiceDescriptor(typeof(DDIAddServicesAttribute), _ => new DDIAddServicesAttribute(), ServiceLifetime.Singleton);`
`14`	`14`
Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ void AddPartial(string methodName, SourceProductionContext ctx, (ImmutableArray<`
`263`	`263`
`264`	`264`	`namespace Microsoft.Extensions.DependencyInjection`
`265`	`265`	`{`
`266`		`- static partial class AttributedServicesExtension`
	`266`	`+ static partial class AddServicesNoReflectionExtension`
`267`	`267`	`{`
`268`	`268`	`static partial void {{methodName}}Services(IServiceCollection services)`
`269`	`269`	`{`