feat: seo changes (#1)

devmegablaster · web-flow · commit cecc1b8237c9 · 2024-12-28T22:19:35.000+05:30
* feat: seo changes

* feat: minor changes

* fix: spell
diff --git a/pkg/jatt.go b/pkg/jatt.go
@@ -2,7 +2,6 @@ package pkg
 
 import (
 	"fmt"
-	"sync"
 	"time"
 
 	"github.com/devmegablaster/jatt/internal/config"
@@ -18,7 +17,6 @@ type Jatt struct {
 	rss      *rss.RssSvc
 	renderer *renderer.Renderer
 	writer   *writer.Writer
-	wg       sync.WaitGroup
 }
 
 func NewJatt(cfg config.JattConfig) *Jatt {
@@ -37,20 +35,10 @@ func (j *Jatt) Run() {
 	renderedFiles := j.renderer.Render(files)
 
 	var feed []byte
-	j.wg.Add(1)
-	go j.rss.GenerateFeed(&j.wg, files, renderedFiles, feed)
-
-	j.wg.Add(1)
-	go j.writer.WriteFiles(&j.wg, renderedFiles)
-
-	j.wg.Wait()
-
-	j.wg.Add(1)
-	go j.writer.CopyStatic(&j.wg)
-	j.wg.Add(1)
-	go j.writer.WriteRSSFeed(&j.wg, feed)
-
-	j.wg.Wait()
+	j.rss.GenerateFeed(files, renderedFiles, feed)
+	j.writer.WriteFiles(renderedFiles)
+	j.writer.CopyStatic()
+	j.writer.WriteRSSFeed(feed)
 
 	timeEnd := time.Now()
 	fmt.Println(styles.StatsStyle.Render(fmt.Sprintf("\n⚡Took %v", timeEnd.Sub(timeStart).Round(time.Millisecond))))
diff --git a/pkg/rss/rss.go b/pkg/rss/rss.go
@@ -3,7 +3,6 @@ package rss
 import (
 	"encoding/xml"
 	"fmt"
-	"sync"
 	"time"
 
 	"github.com/devmegablaster/jatt/internal/config"
@@ -45,9 +44,7 @@ type Item struct {
 	Content     string    `xml:"content:encoded"`
 }
 
-func (r *RssSvc) GenerateFeed(wg *sync.WaitGroup, files []reader.File, renderedFiles []renderer.RenderedFile, target []byte) {
-	defer wg.Done()
-
+func (r *RssSvc) GenerateFeed(files []reader.File, renderedFiles []renderer.RenderedFile, target []byte) {
 	posts := []Item{}
 
 	for _, file := range files {
diff --git a/pkg/writer/writer.go b/pkg/writer/writer.go
@@ -6,7 +6,6 @@ import (
 	"io"
 	"os"
 	"strings"
-	"sync"
 
 	"github.com/devmegablaster/jatt/internal/config"
 	"github.com/devmegablaster/jatt/pkg/renderer"
@@ -23,9 +22,7 @@ func NewWriter(cfg config.JattConfig) *Writer {
 	}
 }
 
-func (w *Writer) WriteFiles(wg *sync.WaitGroup, files []renderer.RenderedFile) {
-	defer wg.Done()
-
+func (w *Writer) WriteFiles(files []renderer.RenderedFile) {
 	w.RemoveOldOutput()
 	w.CreateOutputDir()
 
@@ -84,9 +81,7 @@ func (w *Writer) WriteFile(file renderer.RenderedFile) error {
 	return nil
 }
 
-func (w *Writer) CopyStatic(wg *sync.WaitGroup) error {
-	defer wg.Done()
-
+func (w *Writer) CopyStatic() error {
 	staticDir, err := os.ReadDir("static")
 	if err != nil {
 		return err
@@ -112,9 +107,7 @@ func (w *Writer) CopyStatic(wg *sync.WaitGroup) error {
 	return nil
 }
 
-func (w *Writer) WriteRSSFeed(wg *sync.WaitGroup, feed []byte) {
-	defer wg.Done()
-
+func (w *Writer) WriteRSSFeed(feed []byte) {
 	outputDir := w.cfg.SiteConfig.OutputDir
 	err := os.WriteFile(outputDir+"/rss.xml", feed, 0644)
 	if err != nil {
diff --git a/templates/default.templ b/templates/default.templ
@@ -7,7 +7,8 @@ import (
 )
 
 templ Default(siteCfg config.SiteConfig, navCfg config.NavConfig, anaCfg config.AnalyticsConfig, fm reader.FrontMatter, component templ.Component) {
-	<html>
+	<!DOCTYPE html>
+	<html lang="en">
 		<head>
 			@SEO(fm, siteCfg)
 			@GlobalStyles()
diff --git a/templates/default_templ.go b/templates/default_templ.go
diff --git a/templates/home.templ b/templates/home.templ
@@ -4,7 +4,7 @@ import "github.com/devmegablaster/jatt/internal/config"
 
 templ Home(cfg config.HomeConfig) {
 	<div class="home-container">
-		<img src={ cfg.Image } class="home-image"/>
+		<img src={ cfg.Image } alt={ cfg.Name } class="home-image"/>
 		<div class="name-description-container">
 			<h1 class="home-name">{ cfg.Name }</h1>
 			<p class="home-description">{ cfg.Description }</p>
diff --git a/templates/home_templ.go b/templates/home_templ.go
diff --git a/templates/seo.templ b/templates/seo.templ
@@ -21,5 +21,9 @@ templ SEO(frontMatter reader.FrontMatter, cfg config.SiteConfig) {
 			content={ cfg.Description }
 		}
 	/>
+	<meta charset="utf-8"/>
 	<meta name="author" content={ cfg.Author }/>
+	<meta http-equiv="content-language" content="en"/>
+	<link rel="apple-touch-icon" href="/apple-touch-icon.png"/>
+	<link rel="icon" href="favicon.ico" type="image/x-icon"/>
 }
diff --git a/templates/seo_templ.go b/templates/seo_templ.go

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,8 @@ import (`
`7`	`7`	`)`
`8`	`8`
`9`	`9`	`templ Default(siteCfg config.SiteConfig, navCfg config.NavConfig, anaCfg config.AnalyticsConfig, fm reader.FrontMatter, component templ.Component) {`
`10`		`- <html>`
	`10`	`+ <!DOCTYPE html>`
	`11`	`+ <html lang="en">`
`11`	`12`	`<head>`
`12`	`13`	`@SEO(fm, siteCfg)`
`13`	`14`	`@GlobalStyles()`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,9 @@ templ SEO(frontMatter reader.FrontMatter, cfg config.SiteConfig) {`
`21`	`21`	`content={ cfg.Description }`
`22`	`22`	`}`
`23`	`23`	`/>`
	`24`	`+ <meta charset="utf-8"/>`
`24`	`25`	`<meta name="author" content={ cfg.Author }/>`
	`26`	`+ <meta http-equiv="content-language" content="en"/>`
	`27`	`+ <link rel="apple-touch-icon" href="/apple-touch-icon.png"/>`
	`28`	`+ <link rel="icon" href="favicon.ico" type="image/x-icon"/>`
`25`	`29`	`}`