Normalize gmp_cmp() to -1/0/+1

Girgias · Girgias · commit 0b5b9472ffd7 · 2024-11-27T15:10:49.000Z
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -481,7 +481,8 @@ static int gmp_compare(zval *op1, zval *op2) /* {{{ */
 		}
 		return ZEND_UNCOMPARABLE;
 	}
-	return mpz_cmp(gmp_op1, gmp_op2);
+
+	return ZEND_THREEWAY_COMPARE(mpz_cmp(gmp_op1, gmp_op2), 0);
 }
 /* }}} */
 
@@ -1436,7 +1437,7 @@ ZEND_FUNCTION(gmp_cmp)
 		GMP_Z_PARAM_INTO_MPZ_PTR(gmpnum_b)
 	ZEND_PARSE_PARAMETERS_END();
 
-	RETURN_LONG(mpz_cmp(gmpnum_a, gmpnum_b));
+	RETURN_LONG(ZEND_THREEWAY_COMPARE(mpz_cmp(gmpnum_a, gmpnum_b), 0));
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,8 @@ static int gmp_compare(zval op1, zval op2) /* {{{ */`
`481`	`481`	`}`
`482`	`482`	`return ZEND_UNCOMPARABLE;`
`483`	`483`	`}`
`484`		`- return mpz_cmp(gmp_op1, gmp_op2);`
	`484`	`+`
	`485`	`+ return ZEND_THREEWAY_COMPARE(mpz_cmp(gmp_op1, gmp_op2), 0);`
`485`	`486`	`}`
`486`	`487`	`/* }}} */`
`487`	`488`
`@@ -1436,7 +1437,7 @@ ZEND_FUNCTION(gmp_cmp)`
`1436`	`1437`	`GMP_Z_PARAM_INTO_MPZ_PTR(gmpnum_b)`
`1437`	`1438`	`ZEND_PARSE_PARAMETERS_END();`
`1438`	`1439`
`1439`		`- RETURN_LONG(mpz_cmp(gmpnum_a, gmpnum_b));`
	`1440`	`+ RETURN_LONG(ZEND_THREEWAY_COMPARE(mpz_cmp(gmpnum_a, gmpnum_b), 0));`
`1440`	`1441`	`}`
`1441`	`1442`	`/* }}} */`
`1442`	`1443`