#1559: Fix duplicated PATH entry (#1566)

Co-authored-by: Jörg Hohwiller <[email protected]>

Author: jan-vcapgemini

CHANGELOG.adoc

@@ -11,6 +11,7 @@ Release with new features and bugfixes:
 * https://github.com/devonfw/IDEasy/issues/1169[#1169]: mklink fails if link already exists
 * https://github.com/devonfw/IDEasy/issues/1553[#1553]: IDEasy is slow since 2025.09.001
 * https://github.com/devonfw/IDEasy/issues/1555[#1555]: Handle npm_config_prefix environment variable
+* https://github.com/devonfw/IDEasy/issues/1559[#1559]: IDEasy MSI installer creates multiple PATH entries
 * https://github.com/devonfw/IDEasy/issues/1551[#1551]: Display network connection issues in status
 * https://github.com/devonfw/IDEasy/issues/1560[#1560]: Enable trace logging in IDEasy setup script
 

cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java

@@ -227,7 +227,7 @@ private void installIdeasyWindowsEnv(Path ideRoot, Path installationPath) {
             + "Otherwise all is correct and you can continue.");
         this.context.askToContinue("Are you sure you want to override your PATH?");
       } else {
-        path.removeEntries(s -> s.endsWith(IDE_BIN));
+        path.removeEntries(s -> s.endsWith(IDE_INSTALLATION_BIN));
       }
       path.getEntries().add(ideasyBinPath.toString());
       helper.setUserEnvironmentValue(IdeVariables.PATH.getName(), path.toString());

cli/src/test/java/com/devonfw/tools/ide/tool/IdeasyCommandletTest.java

@@ -37,7 +37,34 @@ public void testRemoveObsoleteEntryFromWindowsPath() {
     assertThat(IdeasyCommandlet.removeObsoleteEntryFromWindowsPath(path)).isEqualTo(path);
   }
 
-  /** Test of {@link IdeasyCommandlet#installIdeasy(Path)}. */
+  /**
+   * Tests if the installation on windows did not add a 2nd path to IDEasy to the PATH environment variable and instead removed the old one and updated it.
+   * See:
+   * <a href="https://github.com/devonfw/IDEasy/issues/1559">#1559</a> for reference.
+   */
+  @Test
+  public void testInstallDoesNotAddPathEntryTwiceOnWindows() {
+    // arrange
+    SystemInfo systemInfo = SystemInfoMock.of("windows");
+    IdeTestContext context = newContext("install");
+    context.setIdeRoot(null);
+    context.setSystemInfo(systemInfo);
+    context.getStartContext().setForceMode(true);
+    WindowsHelper helper = context.getWindowsHelper();
+    String originalPath = helper.getUserEnvironmentValue("PATH");
+    IdeasyCommandlet ideasy = new IdeasyCommandlet(context);
+    // act
+    ideasy.installIdeasy(context.getUserHome().resolve("Downloads/ide-cli"));
+    String newPath = originalPath.replace("C:\\projects\\_ide\\installation\\bin;", "");
+    // assert
+    assertThat(helper.getUserEnvironmentValue("PATH")).isEqualTo(newPath + ";" + context.getUserHome().resolve("projects/_ide/installation/bin"));
+  }
+
+  /**
+   * Test of {@link IdeasyCommandlet#installIdeasy(Path)}.
+   *
+   * @param os to use
+   */
   @ParameterizedTest
   @ValueSource(strings = { "windows", "mac", "linux" })
   public void testInstallIdeasy(String os) {
@@ -51,7 +78,7 @@ public void testInstallIdeasy(String os) {
     WindowsHelper helper = context.getWindowsHelper();
     String originalPath = helper.getUserEnvironmentValue("PATH");
     if (systemInfo.isWindows()) {
-      helper.setUserEnvironmentValue("PATH", "C:\\projects\\_ide\\bin;" + originalPath);
+      helper.setUserEnvironmentValue("PATH", "C:\\projects\\_ide\\installation\\bin;" + originalPath);
     }
     Path ideRoot = context.getUserHome().resolve("projects");
     String addedRcLines =
@@ -73,7 +100,8 @@ public void testInstallIdeasy(String os) {
     verifyInstallation(releasePath);
     if (systemInfo.isWindows()) {
       assertThat(helper.getUserEnvironmentValue("IDE_ROOT")).isEqualTo(ideRoot.toString());
-      assertThat(helper.getUserEnvironmentValue("PATH")).isEqualTo(originalPath + ";" + context.getUserHome().resolve("projects/_ide/installation/bin"));
+      String newPath = originalPath.replace("C:\\projects\\_ide\\installation\\bin;", "");
+      assertThat(helper.getUserEnvironmentValue("PATH")).isEqualTo(newPath + ";" + context.getUserHome().resolve("projects/_ide/installation/bin"));
       assertThat(context.getUserHome().resolve(".gitconfig")).hasContent("[core]\nlongpaths = true");
     }
     assertThat(context.getUserHome().resolve(".bashrc")).hasContent(addedRcLines);