#1208: #1231: write version file on installation (#1265)

Author: hohwille

cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java

@@ -1317,4 +1317,13 @@ public void reload() {
     this.variables = null;
     this.customToolRepository = null;
   }
+
+  @Override
+  public void writeVersionFile(VersionIdentifier version, Path installationPath) {
+
+    assert (Files.isDirectory(installationPath));
+    Path versionFile = installationPath.resolve(FILE_SOFTWARE_VERSION);
+    getFileAccess().writeFileContent(version.toString(), versionFile);
+  }
+
 }

cli/src/main/java/com/devonfw/tools/ide/context/IdeContext.java

@@ -719,4 +719,10 @@ default String findBashRequired() {
    */
   void logIdeHomeAndRootStatus();
 
+  /**
+   * @param version the {@link VersionIdentifier} to write.
+   * @param installationPath the {@link Path directory} where to write the version to a {@link #FILE_SOFTWARE_VERSION version file}.
+   */
+  void writeVersionFile(VersionIdentifier version, Path installationPath);
+
 }

cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java

@@ -173,6 +173,7 @@ public void installIdeasy(Path cwd) {
     for (Path installationArtifact : installationArtifacts) {
       fileAccess.copy(installationArtifact, ideasyVersionPath);
     }
+    this.context.writeVersionFile(IdeVersion.getVersionIdentifier(), ideasyVersionPath);
     fileAccess.symlink(ideasyVersionPath, installationPath);
     addToShellRc(BASHRC, ideRoot, null);
     addToShellRc(ZSHRC, ideRoot, "autoload -U +X bashcompinit && bashcompinit");

cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java

@@ -1,10 +1,8 @@
 package com.devonfw.tools.ide.tool;
 
-import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.LinkOption;
 import java.nio.file.Path;
-import java.nio.file.StandardOpenOption;
 import java.util.Collection;
 import java.util.Set;
 
@@ -223,11 +221,7 @@ public ToolInstallation installTool(GenericVersionRange version, ProcessContext
     }
     fileAccess.mkdirs(installationPath.getParent());
     fileAccess.extract(downloadedToolFile, installationPath, this::postExtract, extract);
-    try {
-      Files.writeString(toolVersionFile, resolvedVersion.toString(), StandardOpenOption.CREATE_NEW);
-    } catch (IOException e) {
-      throw new IllegalStateException("Failed to write version file " + toolVersionFile, e);
-    }
+    this.context.writeVersionFile(resolvedVersion, installationPath);
     this.context.debug("Installed {} in version {} at {}", this.tool, resolvedVersion, installationPath);
     return createToolInstallation(installationPath, resolvedVersion, toolVersionFile, true, processContext, extraInstallation);
   }

cli/src/test/java/com/devonfw/tools/ide/tool/IdeasyCommandletTest.java

@@ -7,6 +7,7 @@
 import org.junit.jupiter.params.provider.ValueSource;
 
 import com.devonfw.tools.ide.context.AbstractIdeContextTest;
+import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.context.IdeTestContext;
 import com.devonfw.tools.ide.os.SystemInfo;
 import com.devonfw.tools.ide.os.SystemInfoMock;
@@ -89,6 +90,7 @@ private void verifyInstallation(Path installationPath) {
     assertThat(installationPath.resolve("IDEasy.pdf")).hasContent("IDEasy.pdf mock");
     assertThat(installationPath.resolve("setup")).hasContent("setup mock");
     assertThat(installationPath.resolve("setup.bat")).hasContent("setup.bat mock");
+    assertThat(installationPath.resolve(IdeContext.FILE_SOFTWARE_VERSION)).hasContent("SNAPSHOT");
   }
 
 }