#1058: fixed missing JAVA_HOME env var (#1100)

Author: jan-vcapgemini

CHANGELOG.adoc

@@ -9,6 +9,7 @@ Release with new features and bugfixes:
 * https://github.com/devonfw/IDEasy/issues/1213[#1213]: Adapt log entry when tool version is not in compatible range
 * https://github.com/devonfw/IDEasy/issues/1272[#1272]: Add name of file with missing namespace to warning message
 * https://github.com/devonfw/IDEasy/issues/1190[#1190]: Add pycharm support to IDEasy
+* https://github.com/devonfw/IDEasy/issues/1058[#1058]: ide create still cannot handle faulty JAVA_HOME
 
 The full list of changes for this release can be found in https://github.com/devonfw/IDEasy/milestone/27?closed=1[milestone 2025.05.001].
 

cli/src/main/java/com/devonfw/tools/ide/process/ProcessContext.java

@@ -1,11 +1,11 @@
 package com.devonfw.tools.ide.process;
 
-import com.devonfw.tools.ide.log.IdeSubLogger;
-
 import java.nio.file.Path;
 import java.util.List;
 import java.util.Objects;
 
+import com.devonfw.tools.ide.log.IdeSubLogger;
+
 /**
  * Wrapper for {@link ProcessBuilder} to simplify its usage and avoid common mistakes and pitfalls.
  */
@@ -26,8 +26,9 @@ public interface ProcessContext extends EnvironmentContext {
   /**
    * Sets the executable command to be {@link #run()}.
    *
-   * @param executable the {@link Path} to the command to be executed by {@link #run()}. Depending on your operating system and the extension of the executable
-   * or OS specific conventions. So e.g. a *.cmd or *.bat file will be called via CMD shell on windows while a *.sh file will be called via Bash, etc.
+   * @param executable the {@link Path} to the command to be executed by {@link #run()}. Depending on your operating system and the extension of the
+   *     executable or OS specific conventions. So e.g. a *.cmd or *.bat file will be called via CMD shell on windows while a *.sh file will be called via Bash,
+   *     etc.
    * @return this {@link ProcessContext} for fluent API calls.
    */
   ProcessContext executable(Path executable);
@@ -165,41 +166,12 @@ default String runAndGetSingleOutput(String executable, String... arguments) {
    */
   default String runAndGetSingleOutput(IdeSubLogger logger, String executable, String... arguments) {
 
-    String errorMessage;
     executable(executable).addArgs(arguments);
     if (logger == null) {
       errorHandling(ProcessErrorHandling.THROW_ERR);
     }
     ProcessResult result = run(ProcessMode.DEFAULT_CAPTURE);
-    if (result.isSuccessful()) {
-      List<String> out = result.getOut();
-      int size = out.size();
-      if (size == 1) {
-        return out.get(0);
-      } else if (size == 0) {
-        errorMessage = "No output received from " + result.getCommand();
-      } else {
-        StringBuilder sb = new StringBuilder();
-        sb.append("Expected single line of output but received ");
-        sb.append(size);
-        sb.append(" lines from ");
-        sb.append(result.getCommand());
-        sb.append(":");
-        for (String line : out) {
-          sb.append("\n");
-          sb.append(line);
-        }
-        errorMessage = sb.toString();
-      }
-    } else {
-      errorMessage = "Command " + result.getCommand() + " failed with exit code " + result.getExitCode();
-    }
-    if (logger == null) {
-      throw new IllegalStateException(errorMessage);
-    } else {
-      logger.log(errorMessage);
-      return null;
-    }
+    return result.getSingleOutput(logger);
   }
 
   /**

cli/src/main/java/com/devonfw/tools/ide/process/ProcessResult.java

@@ -5,6 +5,7 @@
 import com.devonfw.tools.ide.cli.CliProcessException;
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.log.IdeLogLevel;
+import com.devonfw.tools.ide.log.IdeSubLogger;
 
 /**
  * Result of a {@link Process} execution.
@@ -66,6 +67,13 @@ default boolean isSuccessful() {
     return getExitCode() == SUCCESS;
   }
 
+  /**
+   * @param logger the {@link IdeSubLogger logger} to use.
+   * @return the first captured standard out. Will be {@code null} if not captured but redirected.
+   * @throws IllegalStateException if more than one output was captured and the {@link IdeSubLogger logger} was null.
+   */
+  String getSingleOutput(IdeSubLogger logger) throws IllegalStateException;
+
   /**
    * @return the {@link List} with the lines captured on standard out. Will be {@code null} if not captured but redirected.
    */

cli/src/main/java/com/devonfw/tools/ide/process/ProcessResultImpl.java

@@ -7,6 +7,7 @@
 import com.devonfw.tools.ide.cli.CliProcessException;
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.log.IdeLogLevel;
+import com.devonfw.tools.ide.log.IdeSubLogger;
 
 /**
  * Implementation of {@link ProcessResult}.
@@ -56,6 +57,40 @@ public int getExitCode() {
     return this.exitCode;
   }
 
+  @Override
+  public String getSingleOutput(IdeSubLogger logger) throws IllegalStateException {
+    String errorMessage;
+    if (this.isSuccessful()) {
+      List<String> out = this.getOut();
+      int size = out.size();
+      if (size == 1) {
+        return out.getFirst();
+      } else if (size == 0) {
+        errorMessage = "No output received from " + this.getCommand();
+      } else {
+        StringBuilder sb = new StringBuilder();
+        sb.append("Expected single line of output but received ");
+        sb.append(size);
+        sb.append(" lines from ");
+        sb.append(this.getCommand());
+        sb.append(":");
+        for (String line : out) {
+          sb.append("\n");
+          sb.append(line);
+        }
+        errorMessage = sb.toString();
+      }
+    } else {
+      errorMessage = "Command " + this.getCommand() + " failed with exit code " + this.getExitCode();
+    }
+    if (logger == null) {
+      throw new IllegalStateException(errorMessage);
+    } else {
+      logger.log(errorMessage);
+      return null;
+    }
+  }
+
   @Override
   public List<String> getOut() {
 

cli/src/main/java/com/devonfw/tools/ide/tool/mvn/Mvn.java

@@ -13,6 +13,7 @@
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.git.GitContext;
 import com.devonfw.tools.ide.process.ProcessContext;
+import com.devonfw.tools.ide.process.ProcessErrorHandling;
 import com.devonfw.tools.ide.process.ProcessMode;
 import com.devonfw.tools.ide.process.ProcessResult;
 import com.devonfw.tools.ide.step.Step;
@@ -96,12 +97,7 @@ private void createSettingsSecurityFile(Path settingsSecurityFile) {
       secureRandom.nextBytes(randomBytes);
       String base64String = Base64.getEncoder().encodeToString(randomBytes);
 
-      ProcessContext pc = this.context.newProcess().executable("mvn");
-      pc.addArgs("--encrypt-master-password", base64String);
-
-      ProcessResult result = pc.run(ProcessMode.DEFAULT_CAPTURE);
-
-      String encryptedMasterPassword = result.getOut().get(0);
+      String encryptedMasterPassword = retrievePassword("--encrypt-master-password", base64String);
 
       String settingsSecurityXml =
           "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" + "<settingsSecurity>\n" + "  <master>" + encryptedMasterPassword + "</master>\n"
@@ -154,17 +150,20 @@ private String getEncryptedPassword(String variable) {
 
     String input = this.context.askForInput("Please enter secret value for variable " + variable + ":");
 
-    ProcessContext pc = this.context.newProcess().executable("mvn");
-    pc.addArgs("--encrypt-password", input);
-    pc.addArg(getSettingsSecurityProperty());
-    ProcessResult result = pc.run(ProcessMode.DEFAULT_CAPTURE);
-
-    String encryptedPassword = result.getOut().get(0);
+    String encryptedPassword = retrievePassword("--encrypt-password", input);
     this.context.info("Encrypted as " + encryptedPassword);
 
     return encryptedPassword;
   }
 
+  private String retrievePassword(String args, String input) {
+
+    ProcessResult result = runTool(ProcessMode.DEFAULT_CAPTURE, ProcessErrorHandling.LOG_WARNING, this.context.newProcess(), args, input,
+        getSettingsSecurityProperty());
+
+    return result.getSingleOutput(null);
+  }
+
   private Set<String> findVariables(String content) {
 
     Set<String> variables = new LinkedHashSet<>();
@@ -250,11 +249,24 @@ public Path getMavenConfFolder(boolean legacy) {
   public String getMavenArgs() {
     Path mavenConfFolder = getMavenConfFolder(false);
     Path mvnSettingsFile = mavenConfFolder.resolve(Mvn.SETTINGS_FILE);
-    if (!Files.exists(mvnSettingsFile)) {
+    Path settingsSecurityFile = mavenConfFolder.resolve(SETTINGS_SECURITY_FILE);
+    boolean settingsFileExists = Files.exists(mvnSettingsFile);
+    boolean securityFileExists = Files.exists(settingsSecurityFile);
+    if (!settingsFileExists && !securityFileExists) {
       return null;
     }
-    String settingsPath = mvnSettingsFile.toString();
-    return "-s " + settingsPath + " " + getSettingsSecurityProperty();
+    StringBuilder sb = new StringBuilder();
+    if (settingsFileExists) {
+      sb.append("-s ");
+      sb.append(mvnSettingsFile);
+    }
+    if (securityFileExists) {
+      if (!sb.isEmpty()) {
+        sb.append(" ");
+      }
+      sb.append(getSettingsSecurityProperty());
+    }
+    return sb.toString();
   }
 
   private String getSettingsSecurityProperty() {

cli/src/test/java/com/devonfw/tools/ide/tool/mvn/MvnTest.java

@@ -10,7 +10,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import com.devonfw.tools.ide.commandlet.InstallCommandlet;
 import com.devonfw.tools.ide.context.AbstractIdeContextTest;
 import com.devonfw.tools.ide.context.IdeTestContext;
 import com.devonfw.tools.ide.variable.IdeVariables;
@@ -22,7 +21,6 @@ public class MvnTest extends AbstractIdeContextTest {
 
   private static final String PROJECT_MVN = "mvn";
 
-  //private static final Pattern VARIABLE_PATTERN = Pattern.compile("\\$\\[(.*?)\\]");
   private static final Pattern VARIABLE_PATTERN = Pattern.compile("<([^>]+)>(.*?)</\\1>");
 
   /**
@@ -36,11 +34,10 @@ public void testMvnInstall() throws IOException {
     // arrange
     IdeTestContext context = newContext(PROJECT_MVN);
     context.setAnswers("testLogin", "testPassword");
-    InstallCommandlet install = context.getCommandletManager().getCommandlet(InstallCommandlet.class);
-    install.tool.setValueAsString("mvn", context);
+    Mvn mvn = context.getCommandletManager().getCommandlet(Mvn.class);
 
     // act
-    install.run();
+    mvn.run();
 
     // assert
     checkInstallation(context);
@@ -56,14 +53,12 @@ public void testMvnRun() throws IOException {
     // arrange
     IdeTestContext context = newContext(PROJECT_MVN);
     context.setAnswers("testLogin", "testPassword");
-    InstallCommandlet install = context.getCommandletManager().getCommandlet(InstallCommandlet.class);
-    install.tool.setValueAsString("mvn", context);
-    Mvn commandlet = (Mvn) install.tool.getValue();
-    commandlet.arguments.addValue("foo");
-    commandlet.arguments.addValue("bar");
+    Mvn mvn = context.getCommandletManager().getCommandlet(Mvn.class);
+    mvn.arguments.addValue("foo");
+    mvn.arguments.addValue("bar");
 
     // act
-    commandlet.run();
+    mvn.run();
 
     // assert
     assertThat(context).logAtInfo().hasMessage("mvn " + "foo bar");