-
Notifications
You must be signed in to change notification settings - Fork 48
Description
Expected behavior
As a IDEasy product owner, I want to have a reliable process for UpdateURLs so that we do not get stuck.
Therefore we had issue devonfw/ide#1162 implemented via PR https://github.com/devonfw/ide/pull/1203/files.
However this is not working properly.
Actual behavior
IDEasy/.github/workflows/update-urls.yml
Line 30 in 51a16e1
| mvn -B -ntp -Dstyle.color=always exec:java -Dexec.mainClass="com.devonfw.tools.ide.url.UpdateInitiator" -Dexec.args="../ide-urls PT5H30M" |
So the action should start timeout after 5:30 (
PT5H30M) but it is not working:
Steps to reproduce (bug) / Use Case of feature request (enhancement)
- have a look at the screenshot or https://github.com/devonfw/IDEasy/actions/runs/11292746585/job/31409367488
Related/Dependent Issues
See devonfw-ide issue and PR linked above.
Comments/Hints:
Currently we have the timeout check in these places:
- Before an updater is actually started:
if (isTimeoutExpired()) { - Before a version is to be added:
IDEasy/cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Line 709 in 51a16e1
if (isTimeoutExpired()) { - In JSON Updates before a new version is added:
if (isTimeoutExpired()) {
It seems for some reason that is not sufficient.
IMHO it is at least missing here:
IDEasy/cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Line 741 in 51a16e1
| UrlVersion urlVersion = edition.getChild(version); |
Metadata
Metadata
Assignees
Labels
Type
Projects
Status