Merge pull request #14 from devops-coop/feature-indempotence

Feature - idempotence

Author: joshuacherry

scripts/ci.sh

@@ -2,6 +2,11 @@
 set -euxo pipefail
 IFS=$'\n\t'
 
+# Pretty colors.
+red='\033[0;31m'
+green='\033[0;32m'
+neutral='\033[0m'
+
 declare -r OS=${1:-${OS}}
 declare -r PROCESS_CONTROL=${2:-${PROCESS_CONTROL}}
 declare -r SERVER=${3:-${SERVER}}
@@ -25,25 +30,38 @@ function main() {
   # Install role.
   docker cp . "${container}:${WORKSPACE}"
 
-  docker exec -t "${container}" mkdir "${WORKSPACE}/tests/roles" 
-  docker exec -t "${container}" ln -s "${WORKSPACE}/" "${WORKSPACE}/tests/roles/devops-coop.minecraft" 
-  
+  docker exec -t "${container}" mkdir "${WORKSPACE}/tests/roles"
+  docker exec -t "${container}" ln -s "${WORKSPACE}/" "${WORKSPACE}/tests/roles/devops-coop.minecraft"
+
   # Validate syntax
-  docker exec -t "${container}" ansible-playbook \
+  docker exec -t "${container}" env ANSIBLE_FORCE_COLOR=1 ansible-playbook \
               -i "${WORKSPACE}/tests/inventory" \
               --syntax-check \
               -v \
               --extra-vars="minecraft_process_control=${PROCESS_CONTROL} minecraft_server=${SERVER}" \
               "${WORKSPACE}/tests/${SERVER}.yml"
 
   # Install Minecraft.
-  docker exec -t "${container}" ansible-playbook \
+  docker exec -t "${container}" env ANSIBLE_FORCE_COLOR=1 ansible-playbook \
               -i "${WORKSPACE}/tests/inventory" \
               -c local \
               -v \
               --extra-vars="minecraft_process_control=${PROCESS_CONTROL} minecraft_server=${SERVER}" \
               "${WORKSPACE}/tests/${SERVER}.yml"
 
+  # Run Ansible playbook again (idempotence test).
+  idempotence=$(mktemp)
+  docker exec -t "${container}" env ANSIBLE_FORCE_COLOR=1 ansible-playbook \
+              -i "${WORKSPACE}/tests/inventory" \
+              -c local \
+              -v \
+              --extra-vars="minecraft_process_control=${PROCESS_CONTROL} minecraft_server=${SERVER}" \
+              "${WORKSPACE}/tests/${SERVER}.yml" | tee -a $idempotence
+  tail $idempotence \
+  | grep -q 'changed=0.*failed=0' \
+  && (printf ${green}'Idempotence test: pass'${neutral}"\n") \
+  || (printf ${red}'Idempotence test: fail'${neutral}"\n" && exit 1)
+
   # Sleep to allow Minecraft to boot.
   # FIXME: A retry loop checking if it has launched yet would be better.
   sleep 30

tasks/setup/systemd.yml

@@ -14,10 +14,12 @@
     - minecraft.socket
   notify:
     - restart Minecraft
+  register: systemd_service_config
 
 - name: reload systemd
   command: systemctl daemon-reload
   become: true
+  when: systemd_service_config.changed
 
 - name: configure console directory
   template:
@@ -27,6 +29,12 @@
     group: root
     mode: '0644'
 
+- name: check if tmpfile exists
+  stat:
+    path: /etc/tmpfiles.d/{{ minecraft_service_name }}.conf
+  register: minecraft_tmpfile
+
 - name: create console directory
   command: systemd-tmpfiles --create /etc/tmpfiles.d/{{ minecraft_service_name }}.conf
   become: true
+  when: minecraft_tmpfile.stat.islnk