Run action locally and improve release workflow (#152)

Co-authored-by: ChristophShyper <[email protected]>

Author: github-actions[bot]

.github/VERSION-DETECTION.md

@@ -5,22 +5,22 @@ This file demonstrates how the automated version detection works with different
 ## Branch-Based Version Detection
 
 ### ✅ Minor Version Bump (v0.10.2 → v0.11.0)
-**Trigger**: Merging from `feat*` branches
+**Trigger**: Merging from `feat*` branches or commits with `feat:` prefix
 
 ```bash
-# Developer workflow:
+# Feature branch workflow:
 git checkout master
 git checkout -b feat/new-user-authentication
-git commit -m "add OAuth login support"
-git commit -m "add user profile management"
+git commit -m "feat: add OAuth login support"
+git commit -m "feat: add user profile management"
 git push origin feat/new-user-authentication
 
 # Create PR and merge to master
 # Result: Automatic minor version bump v0.10.2 → v0.11.0
 ```
 
 ### ✅ Patch Version Bump (v0.10.2 → v0.10.3)  
-**Trigger**: Merging from any other branch
+**Trigger**: Merging from any other branch or non-feature commits
 
 ```bash
 # Bug fix:
@@ -31,40 +31,90 @@ git commit -m "fix: resolve session timeout issue"
 # Documentation:
 git checkout -b docs/update-api-guide
 git commit -m "docs: update API documentation"
-# Result: v0.10.2 → v0.10.3
+# Result: skipped - docs don't trigger releases
 
 # Refactoring:
 git checkout -b refactor/cleanup-auth
 git commit -m "refactor: simplify authentication flow"
 # Result: v0.10.2 → v0.10.3
 ```
 
-## Detection Priority
+## 🚫 Skipped Releases
+
+The system automatically skips releases for:
+
+- **Dependency updates**: Branches starting with `dep*` or `dependabot*`
+- **Documentation**: Branches starting with `docs*` or commits with `docs:`
+- **Release commits**: Prevents infinite loops from release automation
+- **Version bumps**: Updates to dependencies or version files
+
+```bash
+# These will NOT trigger releases:
+git checkout -b deps/update-actions
+git commit -m "deps: update GitHub Actions to latest"
+
+git checkout -b docs/fix-readme
+git commit -m "docs: fix typos in README"
+
+# Direct commits to master with these patterns also skip releases
+```
+
+## Detection Priority & Logic
 
 The system checks in this order:
 
-1. **Feature branches** (highest priority)
-   - Checks merged branch names for `feat*` pattern
-   - Also checks commit messages for `feat:` prefix
+1. **Skip conditions** (highest priority)
+   - Dependency/docs/release branch patterns
+   - Dependency/docs/release commit message patterns
+   - Existing release commit patterns (prevents loops)
+
+2. **Feature detection** (second priority)
+   - Merged branch names matching `feat*` pattern
+   - Commit messages with `feat:`, `feat():`, or `feature:` prefix
+   - Breaking change indicators (treated as minor for safety)
    - Results in minor version bump (Y)
 
-2. **Everything else** (default)
+3. **Everything else** (default)
    - All other branch merges and commits
    - Results in patch version bump (Z)
 
-## Example Scenarios
+## Enhanced Example Scenarios
+
+| Branch Name     | Commit Message               | Result            | Reason                          |
+|-----------------|------------------------------|-------------------|---------------------------------|
+| `feat/auth`     | "feat: add login system"     | v0.10.2 → v0.11.0 | Feature branch + feat commit    |
+| `fix/bug`       | "fix: resolve crash"         | v0.10.2 → v0.10.3 | Non-feature branch              |
+| `docs/readme`   | "docs: update guide"         | **Skipped**       | Documentation update            |
+| `deps/actions`  | "deps: update actions"       | **Skipped**       | Dependency update               |
+| `fix/bug`       | "feat: add new feature"      | v0.10.2 → v0.11.0 | feat in commit message          |
+| `refactor/code` | "BREAKING CHANGE: new API"   | v0.10.2 → v0.11.0 | Breaking change (conservative)  |
+| `any-branch`    | "🤖 Fully Automated Release" | **Skipped**       | Release commit (prevents loops) |
+
+## Advanced Features
+
+### 🔄 **Infinite Loop Prevention**
+- Detects its own release commits and skips them
+- Prevents cascading releases from automation
+
+### 🎯 **Smart Branch Analysis**
+- Analyzes both branch names and commit messages
+- Handles various conventional commit formats
+- Conservative approach to breaking changes
+
+### ✅ **Validation & Safety**
+- Validates version format before processing
+- Checks for existing tags to prevent duplicates
+- Provides detailed logging for debugging
 
-| Branch Name | Commit Message | Version Change | Reason |
-|-------------|----------------|----------------|---------|
-| `feat/auth` | "add login system" | v0.10.2 → v0.11.0 | feat branch (minor) |
-| `fix/bug` | "fix: resolve crash" | v0.10.2 → v0.10.3 | non-feat branch (patch) |
-| `docs/readme` | "docs: update guide" | v0.10.2 → v0.10.3 | non-feat branch (patch) |
-| `fix/bug` | "feat: add new feature" | v0.10.2 → v0.11.0 | feat in commit (minor) |
-| `refactor/code` | "refactor: improve structure" | v0.10.2 → v0.10.3 | non-feat branch (patch) |
+### 🔧 **Manual Override**
+- Supports manual workflow dispatch
+- Allows override of auto-detection logic
+- Useful for emergency releases or major versions
 
 This ensures that:
+- ✅ Major version (X) requires manual intervention for safety
 - ✅ New features always increment minor version (Y number)
 - ✅ Bug fixes and other changes increment patch version (Z number)
-- ✅ Major version (X) is only incremented manually
-- ✅ Documentation and dependency updates don't trigger releases
-- ✅ No manual version management needed
+- ✅ Documentation and dependency updates don't clutter releases
+- ✅ No manual version management needed for regular development
+- ✅ Robust protection against automation loops

.github/workflows/AUTO-RELEASE.yml

@@ -63,25 +63,19 @@ jobs:
           echo "✅ Updated Makefile fallback version to: ${VERSION}"
 
       - name: Create release branch and commit changes
-        uses: devops-infra/[email protected]
+        uses: ./
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           target_branch: release/${{ github.event.inputs.version }}
           commit_message: |
-            Automated Release ${{ github.event.inputs.version }}
-            
-            This is an **automated release** created via workflow dispatch.
+            🤖 Automated Release ${{ github.event.inputs.version }}
             
             Release Details
             - **Version**: `${{ github.event.inputs.version }}`
             - **Type**: `${{ github.event.inputs.release_type }}`
             - **Triggered by**: @${{ github.actor }}
             - **Date**: ${{ steps.date.outputs.date }}
-            
-            Changes in this release
-            - ✅ Updated `action.yml` to reference Docker image `${{ github.event.inputs.version }}`
-            - ✅ Updated `Makefile` fallback version to `${{ github.event.inputs.version }}`
-            
+
             What happens when this PR is merged?
             1. 🐳 Docker images will be built and pushed to Docker Hub and GitHub Packages
             2. 🏷️ A GitHub release will be created with tag `${{ github.event.inputs.version }}`
@@ -94,4 +88,4 @@ jobs:
             **⚠️ Important:** Once merged, this will immediately publish Docker images to production registries.
             
             ---
-            *This release was created automatically. No manual intervention required.*
+            *🤖 Fully automated release - zero manual intervention required!*

.github/workflows/AUTO-VERSION.yml

@@ -70,14 +70,21 @@ jobs:
           echo "$COMMIT_MESSAGES"
           
           # Skip release for dependency and docs updates
-          if echo "$MERGED_BRANCHES" | grep -iE "^dep|^dependabot|^docs|/dep|/docs"; then
-            echo "Skipping release for dependency/docs updates"
+          if echo "$MERGED_BRANCHES" | grep -iE "^dep|^dependabot|^docs|^release|/dep|/docs|/release"; then
+            echo "Skipping release for dependency/docs/release updates"
             echo "should_release=false" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          if echo "$COMMIT_MESSAGES" | grep -i "^dep:\|^docs:\|^dependencies:\|^dependency:"; then
-            echo "Skipping release for dependency/docs commits"
+          if echo "$COMMIT_MESSAGES" | grep -iE "^dep:|^docs:|^dependencies:|^dependency:|^release:|update.*dependenc|bump.*version"; then
+            echo "Skipping release for dependency/docs/version update commits"
+            echo "should_release=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+          
+          # Skip if this is already a release commit to prevent infinite loops
+          if echo "$COMMIT_MESSAGES" | grep -E "^🤖 Fully Automated Release|^🤖 Automated Release"; then
+            echo "Skipping release for release commits to prevent loops"
             echo "should_release=false" >> $GITHUB_OUTPUT
             exit 0
           fi
@@ -89,7 +96,10 @@ jobs:
             if echo "$MERGED_BRANCHES" | grep -iE "^feat|/feat"; then
               VERSION_TYPE="minor"
             # Check for feat in commit messages as fallback
-            elif echo "$COMMIT_MESSAGES" | grep -i "^feat\|feat:"; then
+            elif echo "$COMMIT_MESSAGES" | grep -iE "^feat:|feat\(.*\):|^feature:"; then
+              VERSION_TYPE="minor"
+            # Check for breaking changes (should be major, but we'll be conservative and use minor)
+            elif echo "$COMMIT_MESSAGES" | grep -iE "BREAKING CHANGE|breaking:|^break:"; then
               VERSION_TYPE="minor"
             # Everything else is patch (Z)
             else
@@ -99,8 +109,13 @@ jobs:
           
           echo "Detected version type: $VERSION_TYPE"
           
-          # Calculate new version
+          # Calculate new version with validation
           CURRENT_VERSION=${LATEST_TAG#v}
+          if [[ ! $CURRENT_VERSION =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+            echo "Error: Invalid current version format: $CURRENT_VERSION" >&2
+            exit 1
+          fi
+          
           IFS='.' read -ra VERSION_PARTS <<< "$CURRENT_VERSION"
           MAJOR=${VERSION_PARTS[0]:-0}
           MINOR=${VERSION_PARTS[1]:-0}
@@ -116,10 +131,20 @@ jobs:
             patch)
               NEW_VERSION="v${MAJOR}.${MINOR}.$((PATCH + 1))"
               ;;
+            *)
+              echo "Error: Invalid version type: $VERSION_TYPE" >&2
+              exit 1
+              ;;
           esac
           
           echo "New version: $NEW_VERSION"
           
+          # Validate new version doesn't already exist
+          if git tag -l | grep -q "^${NEW_VERSION}$"; then
+            echo "Error: Version $NEW_VERSION already exists" >&2
+            exit 1
+          fi
+          
           # Set outputs
           echo "should_release=true" >> $GITHUB_OUTPUT
           echo "version_type=$VERSION_TYPE" >> $GITHUB_OUTPUT
@@ -149,7 +174,7 @@ jobs:
           echo "✅ Updated Makefile fallback version to: ${VERSION}"
 
       - name: Create release branch and commit changes
-        uses: devops-infra/[email protected]
+        uses: ./
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           target_branch: release/${{ needs.check_for_release.outputs.new_version }}
@@ -165,11 +190,6 @@ jobs:
             - **Actor**: @${{ github.actor }}
             - **Date**: $(date +'%Y-%m-%d %H:%M:%S UTC')
             
-            🔄 Automated Changes
-            - ✅ Updated `action.yml` Docker image reference
-            - ✅ Updated `Makefile` fallback version
-            - ✅ Version auto-detected from commit messages
-            
             🚀 What happens when merged?
             1. 🐳 Multi-architecture Docker images built and pushed
             2. 🏷️ GitHub release created with auto-generated notes

.github/workflows/RELEASE.yml

@@ -114,30 +114,37 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           TERM: xterm-256color
           VERSION: ${{ steps.version.outputs.version }}
-        run: make push
+        run: |
+          echo "Building and pushing Docker images for version: $VERSION"
+          make push || {
+            echo "❌ Docker build/push failed"
+            exit 1
+          }
+          echo "✅ Docker images built and pushed successfully"
 
       - name: Create GitHub Release
         uses: softprops/[email protected]
         with:
           tag_name: ${{ steps.version.outputs.version }}
-          name: Release ${{ steps.version.outputs.version }}
+          name: ${{ steps.version.outputs.version }}
           body: |
             ## Release ${{ steps.version.outputs.version }}
             
-            This release was automatically created after merging the release PR.
-            
-            ### Docker Images
-            - **Docker Hub:** `devopsinfra/action-commit-push:${{ steps.version.outputs.version }}`
-            - **GitHub Packages:** `ghcr.io/devops-infra/action-commit-push:${{ steps.version.outputs.version }}`
-            
-            Both images are built for `amd64` and `arm64` architectures.
-            
-            ### Usage
+            ### 🚀 Usage
             ```yaml
             - uses: devops-infra/action-commit-push@${{ steps.version.outputs.version }}
+              with:
+                github_token: ${{ secrets.GITHUB_TOKEN }}
+                commit_message: "Your commit message"
             ```
             
-            For full documentation, see the [README](https://github.com/devops-infra/action-commit-push#readme).
+            ### 📦 Docker Images
+            - `docker://devopsinfra/action-commit-push:${{ steps.version.outputs.version }}`
+            - `docker://devopsinfra/action-commit-push:latest`
+            
+            ### 🏗️ Architecture Support
+            - `linux/amd64`
+            - `linux/arm64`
           generate_release_notes: true
           draft: false
           prerelease: false
@@ -152,10 +159,25 @@ jobs:
 
       - name: Clean up release branch
         run: |
+          RELEASE_BRANCH="${{ github.event.pull_request.head.ref }}"
+          echo "Attempting to clean up release branch: $RELEASE_BRANCH"
+          
           # Check if the release branch exists before attempting to delete it
-          if git ls-remote --exit-code origin "${{ github.event.pull_request.head.ref }}"; then
-            echo "Deleting branch \"${{ github.event.pull_request.head.ref }}\"..."
-            git push origin --delete "${{ github.event.pull_request.head.ref }}"
+          if git ls-remote --exit-code --heads origin "$RELEASE_BRANCH" >/dev/null 2>&1; then
+            echo "✅ Branch $RELEASE_BRANCH exists on remote, deleting..."
+            git push origin --delete "$RELEASE_BRANCH" || {
+              echo "⚠️ Warning: Failed to delete remote branch $RELEASE_BRANCH"
+              echo "This is not critical - the branch can be cleaned up manually"
+            }
+            echo "✅ Remote branch $RELEASE_BRANCH deleted successfully"
           else
-            echo "Branch ${{ github.event.pull_request.head.ref }} does not exist. Skipping deletion."
+            echo "ℹ️ Branch $RELEASE_BRANCH does not exist on remote (may have been auto-deleted)"
+          fi
+          
+          # Also try to clean up any local reference
+          if git show-ref --verify --quiet "refs/heads/$RELEASE_BRANCH"; then
+            echo "🧹 Cleaning up local branch reference..."
+            git branch -D "$RELEASE_BRANCH" 2>/dev/null || true
           fi
+          
+          echo "✅ Branch cleanup completed"