replace testify with standard lib to resolve unknown panic errors

References:
* stretchr/testify#316
* stretchr/testify#119

Author: bzon

Makefile

@@ -37,12 +37,11 @@ windows: create_bin_dir
 	GOOS=windows GOARCH=${GOARCH} go build ${LDFLAGS} -o ${BINDIR}/${BINARY}-windows-${GOARCH}.exe . 
 
 test: getdep
-	echo Performing a go test
-	go test ./... -v -failfast
+	rm -f ~/.gitlabctl.yaml
+	go test -v ./... -failfast
 
 coverage: getdep
-	echo Performing test with coverage
-	go test ./... -v -failfast -coverprofile=coverage.txt -covermode=atomic
+	go test -v ./... -failfast -coverprofile=coverage.txt -covermode=atomic
 
 getdep:
 	go get -v ./...

cmd/desc_branch_test.go

@@ -22,8 +22,6 @@ package cmd
 
 import (
 	"testing"
-
-	"github.com/stretchr/testify/require"
 )
 
 func TestDescBranchCmd(t *testing.T) {
@@ -34,17 +32,17 @@ func TestDescBranchCmd(t *testing.T) {
 		expect   testResult
 	}{
 		{
-			name: "describe project with id 11 master branch",
+			name: "describe project master branch",
 			flagsMap: map[string]string{
-				"project": "11",
+				"project": "Group2/project12",
 			},
 			args:   []string{"master"},
 			expect: pass,
 		},
 		{
 			name: "describing a non existent branch fails",
 			flagsMap: map[string]string{
-				"project": "11",
+				"project": "4",
 			},
 			args:   []string{"release-99"},
 			expect: fail,
@@ -60,10 +58,9 @@ func TestDescBranchCmd(t *testing.T) {
 				args:     tc.args,
 			}
 			stdout, execResult := execT.executeCommand()
-			require.Equal(t, tc.expect, execResult,
-				printFlagsTable(tc.flagsMap, stdout))
+			assertEqualResult(t, execResult, tc.expect, printFlagsTable(tc.flagsMap, stdout))
 			if tc.expect == pass {
-				require.Contains(t, stdout, tc.args[0], stdout)
+				assertStringContains(t, stdout, tc.args[0])
 			}
 		})
 	}

cmd/helpers_for_test.go

@@ -26,6 +26,7 @@ import (
 	"io"
 	"log"
 	"os"
+	"strings"
 	"testing"
 
 	"github.com/olekukonko/tablewriter"
@@ -198,3 +199,16 @@ func printFlagsTable(flagsMap map[string]string, c string) string {
 	table.Render()
 	return buff.String()
 }
+
+func assertEqualResult(t *testing.T, got, want testResult, msg string) {
+	if got != want {
+		t.Fatalf("got test result %s, want %s: \n%s",
+			got, want, msg)
+	}
+}
+
+func assertStringContains(t *testing.T, s, contains string) {
+	if !strings.Contains(s, contains) {
+		t.Fatalf("expected to see %s in %s", contains, s)
+	}
+}

cmd/new_branch_test.go

@@ -23,8 +23,6 @@ package cmd
 import (
 	"fmt"
 	"testing"
-
-	"github.com/stretchr/testify/require"
 )
 
 func TestNewBranch(t *testing.T) {
@@ -60,10 +58,9 @@ func TestNewBranch(t *testing.T) {
 			}
 			stdout, execResult := execT.executeCommand()
 			fmt.Println(stdout)
-			require.Equal(t, tc.expect, execResult,
-				printFlagsTable(tc.flagsMap, stdout))
+			assertEqualResult(t, execResult, tc.expect, printFlagsTable(tc.flagsMap, stdout))
 			if tc.expect == pass {
-				require.Contains(t, stdout, tc.args[0], stdout)
+				assertStringContains(t, stdout, tc.args[0])
 				if err := deleteBranch(tc.flagsMap["project"], tc.args[0]); err != nil {
 					tInfo(err)
 				}

cmd/new_user_test.go

@@ -22,8 +22,6 @@ package cmd
 
 import (
 	"testing"
-
-	"github.com/stretchr/testify/require"
 )
 
 func TestNewUser(t *testing.T) {
@@ -62,7 +60,7 @@ func TestNewUser(t *testing.T) {
 
 	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
-
+			// SETUP
 			// Ensure that the user to be created is deleted
 			if tc.expect == pass {
 				if err := deleteUser(tc.args[0]); err != nil {
@@ -78,8 +76,10 @@ func TestNewUser(t *testing.T) {
 			}
 
 			stdout, execResult := execT.executeCommand()
-			require.Equal(t, tc.expect, execResult,
-				printFlagsTable(tc.flagsMap, stdout))
+			assertEqualResult(t, execResult, tc.expect, printFlagsTable(tc.flagsMap, stdout))
+			if tc.expect == pass {
+				assertStringContains(t, stdout, tc.args[0])
+			}
 		})
 	}