Skip to content

Commit e0d30c3

Browse files
authored
quote build_name and build_number (#485)
1 parent fb72910 commit e0d30c3

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

artifactory.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2953,6 +2953,7 @@ def _get_info(self, build_name, build_number=""):
29532953
# maven-demo/1-build-snapshot => maven-demo%2F1-build-snapshot
29542954
url = urllib.parse.quote(build_name, safe="")
29552955
if build_number:
2956+
build_number = urllib.parse.quote(str(build_number), safe="")
29562957
url += f"/{build_number}"
29572958
return self._get_build_api_response(url)
29582959

@@ -2970,6 +2971,9 @@ def get_build_diff(self, build_name, build_number1, build_number2):
29702971
:param build_number2: number of second build to compare
29712972
:return: (dict) json response with difference
29722973
"""
2974+
build_name = urllib.parse.quote(build_name, safe="")
2975+
build_number1 = urllib.parse.quote(str(build_number1), safe="")
2976+
build_number2 = urllib.parse.quote(str(build_number2), safe="")
29732977
url = f"{build_name}/{build_number1}?diff={build_number2}"
29742978
return self._get_build_api_response(url)
29752979

@@ -3011,6 +3015,8 @@ def promote_build(
30113015
:param fail_fast: fail and abort the operation upon receiving an error. Default: true
30123016
:return:
30133017
"""
3018+
build_name = urllib.parse.quote(build_name, safe="")
3019+
build_number = urllib.parse.quote(str(build_number), safe="")
30143020
url = f"{self.drive}/api/build/promote/{build_name}/{build_number}"
30153021

30163022
if not isinstance(properties, dict):

0 commit comments

Comments
 (0)