Skip to content

Commit 8711bd0

Browse files
author
Martin Wirth
committed
note missing access to improve tests for now and adjust temperature test value to not resemble the default of the current langchain4j default value in preparation for future tests
remove unnecessary semicolon
1 parent 9f93cae commit 8711bd0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/main/java/com/devoxx/genie/chatmodel/cloud/azureopenai/AzureOpenAIChatModelFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
public class AzureOpenAIChatModelFactory implements ChatModelFactory {
2020

21-
private final ModelProvider MODEL_PROVIDER = ModelProvider.AzureOpenAI;;
21+
private final ModelProvider MODEL_PROVIDER = ModelProvider.AzureOpenAI;
2222

2323
@Override
2424
public ChatLanguageModel createChatModel(@NotNull ChatModel chatModel) {

src/test/java/com/devoxx/genie/chatmodel/cloud/azureopenai/AzureOpenAiChatModelFactoryTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.devoxx.genie.ui.settings.DevoxxGenieStateService;
77
import com.intellij.openapi.application.ApplicationManager;
88
import com.intellij.testFramework.ServiceContainerUtil;
9+
import dev.langchain4j.model.azure.AzureOpenAiChatModel;
910
import dev.langchain4j.model.chat.ChatLanguageModel;
1011
import org.junit.jupiter.api.BeforeEach;
1112
import org.junit.jupiter.api.Test;
@@ -38,12 +39,13 @@ void createChatModel() {
3839
AzureOpenAIChatModelFactory factory = new AzureOpenAIChatModelFactory();
3940
ChatModel chatModel = new ChatModel();
4041
chatModel.setModelName("gpt-3.5-turbo");
41-
chatModel.setTemperature(0.7);
42+
chatModel.setTemperature(0.6);
4243
chatModel.setMaxTokens(100);
4344

4445
ChatLanguageModel result = factory.createChatModel(chatModel);
4546

46-
assertThat(result).isNotNull();
47+
// cannot verify more because model does not offer more access to data inside
48+
assertThat(result).isInstanceOf(AzureOpenAiChatModel.class);
4749
}
4850

4951
@Test

0 commit comments

Comments
 (0)