tests: enable sync tests

Author: FabianKramm

e2e/tests/sync/sync.go

@@ -38,7 +38,6 @@ var _ = DevSpaceDescribe("sync", func() {
 	})
 
 	ginkgo.It("devspace sync should override permissions on initial sync", func() {
-		ginkgo.Skip("permission not synced")
 		tempDir, err := framework.CopyToTempDir("tests/sync/testdata/permissions")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
@@ -272,7 +271,6 @@ var _ = DevSpaceDescribe("sync", func() {
 	})
 
 	ginkgo.It("should sync to a pod and watch changes", func() {
-		ginkgo.Skip("error selecting container: couldn't find a pod / container with everything selector")
 		tempDir, err := framework.CopyToTempDir("tests/sync/testdata/sync-simple")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
@@ -340,7 +338,6 @@ var _ = DevSpaceDescribe("sync", func() {
 	})
 
 	ginkgo.It("should sync to a pod and not watch changes with --no-watch", func() {
-		ginkgo.Skip("imageselector issue")
 		tempDir, err := framework.CopyToTempDir("tests/sync/testdata/sync-simple")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
@@ -389,7 +386,6 @@ var _ = DevSpaceDescribe("sync", func() {
 	})
 
 	ginkgo.It("should sync to a pod container with --container and --container-path", func() {
-		ginkgo.Skip("error selecting container: couldn't find a pod / container with everything selector")
 		tempDir, err := framework.CopyToTempDir("tests/sync/testdata/sync-containers")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
@@ -454,7 +450,6 @@ var _ = DevSpaceDescribe("sync", func() {
 	})
 
 	ginkgo.It("should sync to a pod container with excludeFile, downloadExcludeFile, and uploadExcludeFile configuration", func() {
-		ginkgo.Skip("todo")
 		tempDir, err := framework.CopyToTempDir("tests/sync/testdata/sync-exclude-file")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)

pkg/devspace/build/builder/testing/fake.go

@@ -1,20 +1,19 @@
 package testing
 
 import (
-	"github.com/loft-sh/devspace/pkg/devspace/config/localcache"
-	"github.com/loft-sh/devspace/pkg/util/log"
+	devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
 )
 
 // Builder is a fake implementation of the Interface interface
 type Builder struct {
 }
 
 // ShouldRebuild is a fake implementation of the function
-func (b *Builder) ShouldRebuild(cache *localcache.CacheConfig, forceRebuild, ignoreContextPathChanges bool) (bool, error) {
+func (b *Builder) ShouldRebuild(ctx *devspacecontext.Context, forceRebuild bool) (bool, error) {
 	return forceRebuild, nil
 }
 
 // Build is a fake implementation of the function
-func (b *Builder) Build(log log.Logger) error {
+func (b *Builder) Build(ctx *devspacecontext.Context) error {
 	return nil
 }

pkg/devspace/config/versions/v1beta11/upgrade.go

@@ -191,7 +191,7 @@ func (c *Config) Upgrade(log log.Logger) (config.Config, error) {
 		if image.Build != nil && image.Build.BuildKit != nil && image.Build.BuildKit.SkipPush {
 			nextConfig.Images[imageName].SkipPush = true
 		}
-		if image.Build.Docker != nil {
+		if image.Build != nil && image.Build.Docker != nil {
 			nextConfig.Images[imageName].Docker = &next.DockerConfig{
 				PreferMinikube:  image.Build.Docker.PreferMinikube,
 				DisableFallback: image.Build.Docker.DisableFallback,
@@ -200,7 +200,7 @@ func (c *Config) Upgrade(log log.Logger) (config.Config, error) {
 				Args:            image.Build.Docker.Args,
 			}
 		}
-		if image.Build.BuildKit != nil {
+		if image.Build != nil && image.Build.BuildKit != nil {
 			nextConfig.Images[imageName].BuildKit = &next.BuildKitConfig{
 				PreferMinikube: image.Build.BuildKit.PreferMinikube,
 				Args:           image.Build.BuildKit.Args,
@@ -220,7 +220,7 @@ func (c *Config) Upgrade(log log.Logger) (config.Config, error) {
 				}
 			}
 		}
-		if image.Build.Custom != nil {
+		if image.Build != nil && image.Build.Custom != nil {
 			nextConfig.Images[imageName].Custom = &next.CustomConfig{
 				Command:  image.Build.Custom.Command,
 				OnChange: image.Build.Custom.OnChange,
@@ -241,7 +241,7 @@ func (c *Config) Upgrade(log log.Logger) (config.Config, error) {
 				})
 			}
 		}
-		if image.Build.Kaniko != nil {
+		if image.Build != nil && image.Build.Kaniko != nil {
 			nextConfig.Images[imageName].Kaniko = &next.KanikoConfig{
 				SnapshotMode:        image.Build.Kaniko.SnapshotMode,
 				Image:               image.Build.Kaniko.Image,