refactor: add functions, refactor stderr logging

Author: FabianKramm

cmd/deploy.go

@@ -309,12 +309,16 @@ func runPipeline(ctx *devspacecontext.Context, f factory.Factory, forceLeader bo
 	}
 	ctx.Log.Debugf("Marked project excluded: %v", ctx.Config.Config().Name)
 
-	// get a writer
-	writer := ctx.Log.Writer(ctx.Log.GetLevel())
-	defer writer.Close()
+	// get a stdout writer
+	stdoutWriter := ctx.Log.Writer(ctx.Log.GetLevel(), true)
+	defer stdoutWriter.Close()
+
+	// get a stderr writer
+	stderrWriter := ctx.Log.Writer(logrus.WarnLevel, true)
+	defer stderrWriter.Close()
 
 	// start pipeline
-	err = pipe.Run(ctx.WithLogger(logpkg.NewStreamLoggerWithFormat(writer, ctx.Log.GetLevel(), logpkg.TimeFormat)))
+	err = pipe.Run(ctx.WithLogger(logpkg.NewStreamLoggerWithFormat(stdoutWriter, stderrWriter, ctx.Log.GetLevel(), logpkg.TimeFormat)))
 	if err != nil {
 		return err
 	}

cmd/use/namespace.go

@@ -57,13 +57,6 @@ func (cmd *namespaceCmd) RunUseNamespace(f factory.Factory, cobraCmd *cobra.Comm
 
 	// Check if current kube context belongs to a space
 	kubeLoader := client.KubeConfigLoader()
-	isSpace, err := kubeLoader.IsCloudSpace(client.CurrentContext())
-	if err != nil {
-		return errors.Errorf("Unable to check if context belongs to Space: %v", err)
-	}
-	if isSpace {
-		return errors.Errorf("Current kube-context belongs to a Space created by DevSpace Cloud. Changing the default namespace for a Space context is not possible.")
-	}
 
 	// Load kube-config
 	kubeConfig, err := kubeLoader.LoadRawConfig()

e2e/tests/dependencies/testdata/git/devspace.yaml

@@ -14,8 +14,7 @@ dependencies:
 
 pipelines:
   dev:
-    steps:
-    - run: |-
-        run_dependency_pipelines dependency
-        run_dependency_pipelines dependency-deploy > dependency.txt
-        run_command dep-test > imports.txt
+    run: |-
+      run_dependency_pipelines dependency
+      run_dependency_pipelines dependency-deploy > dependency.txt
+      dep-test > imports.txt

e2e/tests/deploy/testdata/helm_concurrent_new/devspace.yaml

@@ -9,12 +9,11 @@ deployments:
 
 pipelines:
   deploy:
-    steps:
-      - run: |-
-          echo '{"helm": {"values": {"containers": [{"image":"alpine"}]}}}' > ${devspace.tempFolder}/deployment.yaml
-          
-          create_deployments test1 test2 test3 test4 --from-file test1:${devspace.tempFolder}/deployment.yaml \
-                                                     --from test2:base \
-                                                     --set test3:helm.values.containers[0].image=alpine \
-                                                     --set-string test4:helm.values.containers[0].image=alpine \
-                                                     --set helm.values.containers[0].name=test
+    run: |-
+      echo '{"helm": {"values": {"containers": [{"image":"alpine"}]}}}' > ${devspace.tempFolder}/deployment.yaml
+      
+      create_deployments test1 test2 test3 test4 --from-file test1:${devspace.tempFolder}/deployment.yaml \
+                                                 --from test2:base \
+                                                 --set test3:helm.values.containers[0].image=alpine \
+                                                 --set-string test4:helm.values.containers[0].image=alpine \
+                                                 --set helm.values.containers[0].name=test

e2e/tests/imports/testdata/local/devspace.yaml

@@ -15,16 +15,15 @@ dependencies:
 
 pipelines:
   deploy:
-    steps:
-      - run: |-
-          echo ${devspace.name} > name.txt
-          echo ${devspace.tempFolder} > temp.txt
-          
-          run_dependency_pipelines --all > dependency.txt
-          
-          run_pipelines import1 > import1.txt
-          run_pipelines import2 > import2.txt
-          run_pipelines import2-name > import2-name.txt
-          run_pipelines import3 > import3.txt
+    run: |-
+      echo ${devspace.name} > name.txt
+      echo ${devspace.tempFolder} > temp.txt
+      
+      run_dependency_pipelines --all > dependency.txt
+      
+      run_pipelines import1 > import1.txt
+      run_pipelines import2 > import2.txt
+      run_pipelines import2-name > import2-name.txt
+      run_pipelines import3 > import3.txt
 
-          echo ${DEVSPACE_NAMESPACE}-${devspace.namespace}-${BASE}-${IMPORT1}-${IMPORT2}-${IMPORT3} > vars.txt
+      echo ${DEVSPACE_NAMESPACE}-${devspace.namespace}-${BASE}-${IMPORT1}-${IMPORT2}-${IMPORT3} > vars.txt

e2e/tests/imports/testdata/local/import1.yaml

@@ -9,6 +9,5 @@ vars:
 
 pipelines:
   import1:
-    steps:
-    - run: |-
-        echo ${IMPORT1}
+    run: |-
+      echo ${IMPORT1}

e2e/tests/imports/testdata/local/import2.yaml

@@ -6,10 +6,8 @@ vars:
 
 pipelines:
   import2-name:
-    steps:
-      - run: |-
-          echo ${devspace.name}
+    run: |-
+      echo ${devspace.name}
   import2:
-    steps:
-      - run: |-
-          echo ${IMPORT2}
+    run: |-
+      echo ${IMPORT2}

e2e/tests/imports/testdata/local/import3.yaml

@@ -6,12 +6,10 @@ vars:
 
 pipelines:
   import3:
-    steps:
-      - run: |-
-          echo ${IMPORT3}
+    run: |-
+      echo ${IMPORT3}
   import3-dep:
-    steps:
-      - run: |-
-          echo ${IMPORT3}
-          echo ${devspace.name} > dependency-name.txt
-          echo ${devspace.tempFolder} > dependency-temp.txt
+    run: |-
+      echo ${IMPORT3}
+      echo ${devspace.name} > dependency-name.txt
+      echo ${devspace.tempFolder} > dependency-temp.txt

e2e/tests/pipelines/pipelines.go

@@ -53,7 +53,7 @@ var _ = DevSpaceDescribe("portforward", func() {
 	})
 
 	ginkgo.It("should watch files", func() {
-		tempDir, err := framework.CopyToTempDir("tests/pipelines/testdata/watch")
+		tempDir, err := framework.CopyToTempDir("tests/pipelines/testdata/run_watch")
 		framework.ExpectNoError(err)
 		defer framework.CleanupTempDir(initialDir, tempDir)
 

e2e/tests/pipelines/testdata/exec_container/devspace.yaml

@@ -11,8 +11,7 @@ deployments:
 
 pipelines:
   dev:
-    steps:
-      - run: |-
-          run_default_pipeline deploy
-          
-          echo "Hello World!" | exec_container --image-selector alpine --silent -- cat - > test.txt 
+    run: |-
+      run_default_pipeline deploy
+      
+      echo "Hello World!" | exec_container --image-selector alpine -- cat - > test.txt