refactor: don't allow runtime variables in pipelines

Author: FabianKramm

pkg/devspace/pipeline/engine/pipelinehandler/commands/get_image.go

@@ -11,7 +11,8 @@ import (
 )
 
 type GetImageOptions struct {
-	Only string `long:"only" description:"Displays either only the tag or only the image"`
+	Dependency string `long:"dependency" description:"Retrieves the image from the named dependency"`
+	Only       string `long:"only" description:"Displays either only the tag or only the image"`
 }
 
 func GetImage(ctx *devspacecontext.Context, args []string) error {
@@ -22,7 +23,7 @@ func GetImage(ctx *devspacecontext.Context, args []string) error {
 		return errors.Wrap(err, "parse args")
 	}
 	if len(args) != 1 {
-		return fmt.Errorf("usage: get_image [image_name] [--only=image|tag]")
+		return fmt.Errorf("usage: get_image [--only=image|tag] [--dependency=DEPENDENCY] [image_name]")
 	}
 
 	var (
@@ -36,7 +37,21 @@ func GetImage(ctx *devspacecontext.Context, args []string) error {
 	case "tag":
 		onlyTag = true
 	default:
-		return fmt.Errorf("usage: get_image [image_name] [--only=image|tag]")
+		return fmt.Errorf("usage: get_image [--only=image|tag] [--dependency=DEPENDENCY] [image_name]")
+	}
+
+	if options.Dependency != "" {
+		found := false
+		for _, dep := range ctx.Dependencies {
+			if dep.Name() == options.Dependency {
+				ctx = ctx.AsDependency(dep)
+				found = true
+				break
+			}
+		}
+		if !found {
+			return fmt.Errorf("couldn't find dependency %v", options.Dependency)
+		}
 	}
 
 	_, imageCache, err := runtime.GetImage(ctx.Config, args[0], onlyImage, onlyTag)

pkg/devspace/pipeline/env/env.go

@@ -34,12 +34,13 @@ type envProvider struct {
 }
 
 func (e *envProvider) Get(name string) expand.Variable {
-	v, ok := e.getRuntimeVariable(name)
-	if ok {
-		return v
-	}
+	// Should we enable this?
+	// v, ok := e.getRuntimeVariable(name)
+	// if ok {
+	//	return v
+	// }
 
-	v, ok = e.getVariable(name)
+	v, ok := e.getVariable(name)
 	if ok {
 		return v
 	}
@@ -80,12 +81,13 @@ func (e *envProvider) getRuntimeVariable(name string) (expand.Variable, bool) {
 }
 
 func (e *envProvider) Each(visitor func(name string, vr expand.Variable) bool) {
-	for name := range e.config.ListRuntimeVariables() {
-		v, ok := e.getRuntimeVariable(name)
-		if ok {
-			visitor(name, v)
-		}
-	}
+	// Should we enable this?
+	// for name := range e.config.ListRuntimeVariables() {
+	//	v, ok := e.getRuntimeVariable(name)
+	//	if ok {
+	//		visitor(name, v)
+	//	}
+	// }
 
 	for name := range e.config.Variables() {
 		v, ok := e.getVariable(name)