Skip to content

Commit 78e6b83

Browse files
committed
e2e: add test for namespaced dependency
Signed-off-by: Luca Di Maio <[email protected]>
1 parent 02697a2 commit 78e6b83

File tree

3 files changed

+61
-3
lines changed

3 files changed

+61
-3
lines changed

e2e/tests/dependencies/dependencies.go

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@ package dependencies
33
import (
44
"bytes"
55
"context"
6-
ginkgo "github.com/onsi/ginkgo/v2"
7-
"github.com/onsi/gomega"
8-
"github.com/sirupsen/logrus"
96
"os"
107
"path/filepath"
118
"time"
129

10+
ginkgo "github.com/onsi/ginkgo/v2"
11+
"github.com/onsi/gomega"
12+
"github.com/sirupsen/logrus"
13+
1314
"github.com/loft-sh/devspace/pkg/devspace/config/versions/latest"
1415
dependencyutil "github.com/loft-sh/devspace/pkg/devspace/dependency/util"
1516
"github.com/loft-sh/devspace/pkg/devspace/kubectl/selector"
@@ -208,6 +209,43 @@ dep2dep2wait
208209
framework.ExpectEqual(len(list.Items), 0)
209210
})
210211

212+
ginkgo.It("should deploy dependency in custom namespace", func() {
213+
tempDir, err := framework.CopyToTempDir("tests/dependencies/testdata/namespace")
214+
framework.ExpectNoError(err)
215+
defer framework.CleanupTempDir(initialDir, tempDir)
216+
217+
ns, err := kubeClient.CreateNamespace("dependencies")
218+
framework.ExpectNoError(err)
219+
defer func() {
220+
err := kubeClient.DeleteNamespace(ns)
221+
framework.ExpectNoError(err)
222+
err = kubeClient.DeleteNamespace("custom")
223+
framework.ExpectNoError(err)
224+
}()
225+
226+
// create a new dev command and start it
227+
cancelCtx, cancel := context.WithCancel(context.Background())
228+
defer cancel()
229+
230+
devCmd := &cmd.RunPipelineCmd{
231+
GlobalFlags: &flags.GlobalFlags{
232+
NoWarn: true,
233+
Namespace: ns,
234+
},
235+
Pipeline: "dev",
236+
Ctx: cancelCtx,
237+
}
238+
err = devCmd.RunDefault(f)
239+
framework.ExpectNoError(err)
240+
cancel()
241+
242+
// now check if nonExistentNs got created
243+
framework.ExpectNamespace("custom")
244+
245+
framework.ExpectNoError(err)
246+
247+
})
248+
211249
ginkgo.It("should deploy git dependency", func() {
212250
tempDir, err := framework.CopyToTempDir("tests/dependencies/testdata/git")
213251
framework.ExpectNoError(err)
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
version: v1beta10
2+
deployments:
3+
- name: nginx
4+
helm:
5+
componentChart: true
6+
values:
7+
containers:
8+
- image: nginx
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
version: v2beta1
2+
deployments:
3+
nginx:
4+
helm:
5+
values:
6+
containers:
7+
- image: nginx
8+
9+
dependencies:
10+
test-dependency:
11+
path: ./dep1.yaml
12+
namespace: custom

0 commit comments

Comments
 (0)