Merge pull request #2649 from lizardruss/fix-command-k8s-unauthorized

Devspace command fails when cluster is not required

Author: FabianKramm

cmd/run.go

@@ -249,6 +249,13 @@ func (cmd *RunCmd) LoadCommandsConfig(f factory.Factory, configLoader loader.Con
 		client = nil
 	}
 
+	// verify client connectivity / authn / authz
+	_, err = client.KubeClient().Discovery().ServerVersion()
+	if err != nil {
+		log.Debugf("Unable to discover server version: %v", err)
+		client = nil
+	}
+
 	// Parse commands
 	commandsInterface, err := configLoader.LoadWithParser(context.Background(), localCache, client, loader.NewCommandsParser(), configOptions, log)
 	if err != nil {

e2e/tests/command/command.go

@@ -2,12 +2,13 @@ package command
 
 import (
 	"bytes"
-	"github.com/onsi/ginkgo/v2"
 	"os"
+	"path/filepath"
 
 	"github.com/loft-sh/devspace/cmd"
 	"github.com/loft-sh/devspace/cmd/flags"
 	"github.com/loft-sh/devspace/e2e/framework"
+	"github.com/onsi/ginkgo/v2"
 )
 
 var _ = DevSpaceDescribe("command", func() {
@@ -66,4 +67,24 @@ var _ = DevSpaceDescribe("command", func() {
 		framework.ExpectNoError(err)
 		framework.ExpectEqual(stdout.String(), "test123 test456")
 	})
+
+	ginkgo.It("should run command without kubernetes cluster", func() {
+		tempDir, err := framework.CopyToTempDir("tests/command/testdata/command-without-cluster")
+		framework.ExpectNoError(err)
+		defer framework.CleanupTempDir(initialDir, tempDir)
+
+		defer os.Unsetenv("KUBECONFIG")
+		err = os.Setenv("KUBECONFIG", filepath.Join(tempDir, "config"))
+		framework.ExpectNoError(err)
+
+		stdout := &bytes.Buffer{}
+		runCmd := &cmd.RunCmd{
+			GlobalFlags: &flags.GlobalFlags{},
+			Stdout:      stdout,
+			Stderr:      stdout,
+		}
+		err = runCmd.RunRun(f, []string{"test"})
+		framework.ExpectNoError(err)
+		framework.ExpectEqual(stdout.String(), "Hello World")
+	})
 })

e2e/tests/command/testdata/command-without-cluster/config

@@ -0,0 +1,16 @@
+apiVersion: v1
+clusters:
+- cluster:
+    server: https://127.0.0.1:52617
+  name: kind-kind
+contexts:
+- context:
+    cluster: kind-kind
+    user: kind-kind
+  name: kind-kind
+current-context: kind-kind
+kind: Config
+preferences: {}
+users:
+- name: kind-kind
+  user: {}

e2e/tests/command/testdata/command-without-cluster/devspace.yaml

@@ -0,0 +1,6 @@
+version: v2beta1
+name: command-without-cluster
+
+commands:
+  test: |-
+    echo -n "Hello World"