Skip to content

Commit e88d7df

Browse files
committed
e2e: move namespace to var for namespaced dependency
Signed-off-by: Luca Di Maio <[email protected]>
1 parent 98fff1d commit e88d7df

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

e2e/tests/dependencies/dependencies.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,19 +214,23 @@ dep2dep2wait
214214
framework.ExpectNoError(err)
215215
defer framework.CleanupTempDir(initialDir, tempDir)
216216

217+
depNamespace := "custon"
218+
217219
ns, err := kubeClient.CreateNamespace("dependencies")
218220
framework.ExpectNoError(err)
219221
defer func() {
220222
err := kubeClient.DeleteNamespace(ns)
221223
framework.ExpectNoError(err)
222-
err = kubeClient.DeleteNamespace("custom")
224+
err = kubeClient.DeleteNamespace(depNamespace)
223225
framework.ExpectNoError(err)
224226
}()
225227

226228
// create a new dev command and start it
227229
cancelCtx, cancel := context.WithCancel(context.Background())
228230
defer cancel()
229231

232+
os.Setenv("DEP1_NAMESPACE", depNamespace)
233+
defer os.Unsetenv("DEP1_NAMESPACE")
230234
devCmd := &cmd.RunPipelineCmd{
231235
GlobalFlags: &flags.GlobalFlags{
232236
NoWarn: true,
@@ -240,7 +244,7 @@ dep2dep2wait
240244
cancel()
241245

242246
// now check if nonExistentNs got created
243-
framework.ExpectNamespace("custom")
247+
framework.ExpectNamespace(depNamespace)
244248

245249
framework.ExpectNoError(err)
246250

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
version: v2beta1
2+
vars:
3+
DEP1_NAMESPACE:
4+
source: env
5+
default: false
26
deployments:
37
nginx:
48
helm:
59
values:
610
containers:
7-
- image: nginx
11+
- image: nginx
812

913
dependencies:
1014
test-dependency:
1115
path: ./dep1.yaml
12-
namespace: custom
16+
namespace: ${DEP1_NAMESPACE}

0 commit comments

Comments
 (0)