Merge pull request #2630 from FabianKramm/main

FabianKramm · web-flow · commit ec76253901c7 · 2023-04-22T09:27:47.000+02:00
fix: silent hook panic
diff --git a/pkg/devspace/hook/hook.go b/pkg/devspace/hook/hook.go
@@ -200,7 +200,7 @@ func executeHook(ctx devspacecontext.Context, hookConfig *latest.HookConfig, hoo
 	err := hook.Execute(ctx.WithLogger(hookLog), hookConfig, extraEnv)
 	if err != nil {
 		if hookConfig.Silent {
-			return errors.Wrapf(err, "in hook '%s': %s", ansi.Color(hookName(hookConfig), "white+b"), hookWriter.(logpkg.NopCloser).Writer.(*bytes.Buffer).String())
+			return errors.Wrapf(err, "in hook '%s': %s", ansi.Color(hookName(hookConfig), "white+b"), hookWriter.(*logpkg.NopCloser).Writer.(*bytes.Buffer).String())
 		}
 		return errors.Wrapf(err, "in hook '%s'", ansi.Color(hookName(hookConfig), "white+b"))
 	}

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ func executeHook(ctx devspacecontext.Context, hookConfig *latest.HookConfig, hoo`
`200`	`200`	`err := hook.Execute(ctx.WithLogger(hookLog), hookConfig, extraEnv)`
`201`	`201`	`if err != nil {`
`202`	`202`	`if hookConfig.Silent {`
`203`		`- return errors.Wrapf(err, "in hook '%s': %s", ansi.Color(hookName(hookConfig), "white+b"), hookWriter.(logpkg.NopCloser).Writer.(*bytes.Buffer).String())`
	`203`	`+ return errors.Wrapf(err, "in hook '%s': %s", ansi.Color(hookName(hookConfig), "white+b"), hookWriter.(logpkg.NopCloser).Writer.(bytes.Buffer).String())`
`204`	`204`	`}`
`205`	`205`	`return errors.Wrapf(err, "in hook '%s'", ansi.Color(hookName(hookConfig), "white+b"))`
`206`	`206`	`}`