Skip to content

Commit f29b28c

Browse files
committed
fix: fixed persist paths not working in AWS
1 parent 076be2d commit f29b28c

File tree

7 files changed

+13
-12
lines changed

7 files changed

+13
-12
lines changed

docs/pages/configuration/development/replace-pods.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ dev:
251251
persistPaths:
252252
- path: /app
253253
# Optional path on the persistent volume to mount
254-
# volumePath: /my-volume/app
254+
# volumePath: my-volume/app
255255
# Optional name of the container to persist this path
256256
# containerName: my-container
257257
```
@@ -292,13 +292,13 @@ dev:
292292
- imageSelector: my-image/frontend
293293
persistPaths:
294294
- path: /app
295-
volumePath: /app
295+
volumePath: app
296296
persistenceOptions:
297297
name: my-pvc
298298
- imageSelector: my-image/backend
299299
persistPaths:
300300
- path: /backend
301-
volumePath: /app
301+
volumePath: app
302302
persistenceOptions:
303303
name: my-pvc
304304
readOnly: true

docs/pages/configuration/reference.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ replacePods: # struct[] | Which pods should be repl
356356
replaceImage: "" # string | The image that should be used for the pod
357357
persistPaths: # struct[] | Paths that should get persisted in the replaced pod
358358
- path: /app # string | The container path that should get persisted
359-
volumePath: /my-volume/app # string | Optional path on the persistent volume to mount
359+
volumePath: my-volume/app # string | Optional path on the persistent volume to mount
360360
containerName: "" # string | Optional container name in the replaced pod to persist the path
361361
readOnly: false # bool | If the path should get mounted read only
362362
skipPopulate: false # bool | If true, devspace will not try to pre-populate the path

docs/versioned_docs/version-5.17/configuration/development/replace-pods.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ dev:
251251
persistPaths:
252252
- path: /app
253253
# Optional path on the persistent volume to mount
254-
# volumePath: /my-volume/app
254+
# volumePath: my-volume/app
255255
# Optional name of the container to persist this path
256256
# containerName: my-container
257257
```
@@ -281,13 +281,13 @@ dev:
281281
- imageSelector: my-image/frontend
282282
persistPaths:
283283
- path: /app
284-
volumePath: /app
284+
volumePath: app
285285
persistenceOptions:
286286
name: my-pvc
287287
- imageSelector: my-image/backend
288288
persistPaths:
289289
- path: /backend
290-
volumePath: /app
290+
volumePath: app
291291
persistenceOptions:
292292
name: my-pvc
293293
readOnly: true

docs/versioned_docs/version-5.17/configuration/reference.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ replacePods: # struct[] | Which pods should be repl
340340
replaceImage: "" # string | The image that should be used for the pod
341341
persistPaths: # struct[] | Paths that should get persisted in the replaced pod
342342
- path: /app # string | The container path that should get persisted
343-
volumePath: /my-volume/app # string | Optional path on the persistent volume to mount
343+
volumePath: my-volume/app # string | Optional path on the persistent volume to mount
344344
containerName: "" # string | Optional container name in the replaced pod to persist the path
345345
readOnly: false # bool | If the path should get mounted read only
346346
persistenceOptions: # struct | Additional options for persistPaths

docs/versioned_docs/version-5.18/configuration/development/replace-pods.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ dev:
251251
persistPaths:
252252
- path: /app
253253
# Optional path on the persistent volume to mount
254-
# volumePath: /my-volume/app
254+
# volumePath: my-volume/app
255255
# Optional name of the container to persist this path
256256
# containerName: my-container
257257
```
@@ -292,13 +292,13 @@ dev:
292292
- imageSelector: my-image/frontend
293293
persistPaths:
294294
- path: /app
295-
volumePath: /app
295+
volumePath: app
296296
persistenceOptions:
297297
name: my-pvc
298298
- imageSelector: my-image/backend
299299
persistPaths:
300300
- path: /backend
301-
volumePath: /app
301+
volumePath: app
302302
persistenceOptions:
303303
name: my-pvc
304304
readOnly: true

docs/versioned_docs/version-5.18/configuration/reference.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ replacePods: # struct[] | Which pods should be repl
356356
replaceImage: "" # string | The image that should be used for the pod
357357
persistPaths: # struct[] | Paths that should get persisted in the replaced pod
358358
- path: /app # string | The container path that should get persisted
359-
volumePath: /my-volume/app # string | Optional path on the persistent volume to mount
359+
volumePath: my-volume/app # string | Optional path on the persistent volume to mount
360360
containerName: "" # string | Optional container name in the replaced pod to persist the path
361361
readOnly: false # bool | If the path should get mounted read only
362362
skipPopulate: false # bool | If true, devspace will not try to pre-populate the path

pkg/devspace/services/podreplace/replace.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,7 @@ func replace(ctx context.Context, client kubectl.Client, pod *selector.SelectedP
380380
copiedPod.Annotations[selector.MatchedContainerAnnotation] = pod.Container.Name
381381
copiedPod.Annotations[ParentHashAnnotation] = parentHash
382382
copiedPod.Annotations[ReplaceConfigHashAnnotation] = configHash
383+
copiedPod.Spec.NodeName = ""
383384

384385
// get pod spec from object
385386
switch t := parent.(type) {

0 commit comments

Comments
 (0)