Skip to content

Commit 135d86d

Browse files
authored
Merge pull request #1361 from merico-dev/fix-jenkins-error
fix: jenkins scm default option error
2 parents 6bcd6f4 + 2e512a8 commit 135d86d

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

internal/pkg/plugin/installer/ci/validate.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ func SetDefault(ciType server.CIServerType) func(option configmanager.RawOptions
2626
if err != nil {
2727
return nil, err
2828
}
29+
// set default value of repoInfo
30+
if err := opts.ProjectRepo.SetDefault(); err != nil {
31+
return nil, err
32+
}
2933
opts.CIFileConfig = opts.Pipeline.BuildCIFileConfig(ciType, opts.ProjectRepo)
3034
return mapz.DecodeStructToMap(opts)
3135
}

internal/pkg/plugin/jenkinspipeline/option.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ func (j *jobOptions) createOrUpdateJob(jenkinsClient jenkins.JenkinsAPI, secretT
7373
SecretToken: secretToken,
7474
FolderName: j.JobName.getJobFolder(),
7575
GitlabConnection: globalConfig.GitlabConnectionID,
76-
RepoURL: string(repoInfo.CloneURL),
76+
RepoURL: string(repoInfo.GetCloneURL()),
7777
RepoOwner: repoInfo.GetRepoOwner(),
78-
RepoName: repoInfo.Repo,
78+
RepoName: repoInfo.GetRepoName(),
7979
RepoCredentialsId: globalConfig.CredentialID,
8080
}
8181
jobScript, err := jenkins.BuildRenderedScript(jobRenderInfo)

internal/pkg/plugin/jenkinspipeline/validate.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ func setJenkinsDefault(options configmanager.RawOptions) (configmanager.RawOptio
2020
return nil, err
2121
}
2222

23+
// set project default value
24+
if err := opts.ProjectRepo.SetDefault(); err != nil {
25+
return nil, err
26+
}
27+
2328
// if jenkins is offline, just use offline Jenkinsfile
2429
if opts.needOfflineConfig() {
2530
opts.CIFileConfig = &cifile.CIFileConfig{

0 commit comments

Comments
 (0)